development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 21:39:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we always reset the code action widget context when the widget is hidden (#162278)

Browse source 
Make sure we always reset the `ctxMenuWidgetVisible` widget context when the widget is hidden

We've seen a handful of reports of keybindings not working. I'm not able to repo this, but the root cause may be that code action's context keys are not being cleared properly

This fixes it to make sure we always reset the context when the widget is closed
This commit is contained in:
Matt Bierner 2022-09-28 16:15:45 -07:00 committed by GitHub
parent 0c22a33a9d
commit b16578ff65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/editor/contrib/codeAction/browser/codeActionWidget.ts
View file

@ -419,7 +419,6 @@ export class CodeActionWidget extends Disposable {
}
public hide() {
this._ctxMenuWidgetVisible.reset();
this.codeActionList.clear();
this._contextViewService.hideContextView();
}
@ -530,6 +529,7 @@ export class CodeActionWidget extends Disposable {
});
this.currentShowingContext = undefined;
this._ctxMenuWidgetVisible.reset();
delegate.onHide(cancelled);
}