mirror of
https://github.com/Microsoft/vscode
synced 2024-09-18 01:58:27 +00:00
fix: remove side effect from some
callback
This commit is contained in:
parent
b0bcc33d34
commit
b13ff339fa
|
@ -816,15 +816,12 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I
|
|||
}
|
||||
|
||||
private _getTerminalObjectIndexById<T extends ExtHostTerminal>(array: T[], id: ExtHostTerminalIdentifier): number | null {
|
||||
let index: number | null = null;
|
||||
array.some((item, i) => {
|
||||
const thisId = item._id;
|
||||
if (thisId === id) {
|
||||
index = i;
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
const index = array.findIndex(item => {
|
||||
return item._id === id;
|
||||
});
|
||||
if (index === -1) {
|
||||
return null;
|
||||
}
|
||||
return index;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue