development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove side effect from some callback

Browse source
This commit is contained in:
Loïc Mangeonjean 2023-06-12 17:02:34 +02:00
parent b0bcc33d34
commit b13ff339fa
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/vs/workbench/api/common/extHostTerminalService.ts
View file

@ -816,15 +816,12 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I
}
private _getTerminalObjectIndexById<T extends ExtHostTerminal>(array: T[], id: ExtHostTerminalIdentifier): number | null {
let index: number | null = null;
array.some((item, i) => {
const thisId = item._id;
if (thisId === id) {
index = i;
return true;
}
return false;
const index = array.findIndex(item => {
return item._id === id;
});
if (index === -1) {
return null;
}
return index;
}