development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix https://github.com/microsoft/vscode/issues/159914 (#168175)

Browse source
This commit is contained in:
Johannes Rieken 2022-12-06 15:55:01 +01:00 committed by GitHub
parent 6adec5fc8e
commit accdf1078f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/editor/contrib/suggest/browser/suggest.ts
View file

@ -382,7 +382,7 @@ CommandsRegistry.registerCommand('_executeCompletionItemProvider', async (access
};
const resolving: Promise<any>[] = [];
const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke });
const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter: triggerCharacter ?? undefined, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke });
for (const item of completions.items) {
if (resolving.length < (maxItemsToResolve ?? 0)) {
resolving.push(item.resolve(CancellationToken.None));

19
src/vs/workbench/api/test/browser/extHostApiCommands.test.ts
View file

@ -722,6 +722,25 @@ suite('ExtHostLanguageFeatureCommands', function () {
// --- suggest
test('triggerCharacter is null when completion provider is called programmatically #159914', async function () {
let actualContext: vscode.CompletionContext | undefined;
disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{
provideCompletionItems(_doc, _pos, _tok, context): any {
actualContext = context;
return [];
}
}, []));
await rpcProtocol.sync();
await commands.executeCommand<vscode.CompletionList>('vscode.executeCompletionItemProvider', model.uri, new types.Position(0, 4));
assert.ok(actualContext);
assert.deepStrictEqual(actualContext, { triggerKind: types.CompletionTriggerKind.Invoke, triggerCharacter: undefined });
});
test('Suggest, back and forth', function () {
disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{
provideCompletionItems(): any {