development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-12 22:37:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Not populating extension when selecting notebook kernel (#197619) (#197810)

Browse source 
When selecting a notebook kernel, prompt was saying
"Select kernel from undefined". "Undefined" here was supported
to be the extension name. When the quick pick items
are generated, they are generated with a value of "label".
Nothing else references or populates a property of "source",
so seems safe to change the code to reference "label" instead.
This commit is contained in:
tomqwpl 2024-01-29 18:37:27 +00:00 committed by GitHub
parent 0d9e0996dd
commit a9ba0672ae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts
View file

@ -600,7 +600,7 @@ export class KernelPickerMRUStrategy extends KernelPickerStrategyBase {
await this._selecteKernel(notebook, selectedKernelPickItem.kernel);
return true;
} else if (isGroupedKernelsPick(selectedKernelPickItem)) {
await this._selectOneKernel(notebook, selectedKernelPickItem.source, selectedKernelPickItem.kernels);
await this._selectOneKernel(notebook, selectedKernelPickItem.label, selectedKernelPickItem.kernels);
return true;
} else if (isSourcePick(selectedKernelPickItem)) {
// selected explicilty, it should trigger the execution?