development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-30 08:06:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

Resolve todos

Browse source
This commit is contained in:
Daniel Imms 2021-05-24 11:59:39 -07:00
parent 47b7320c1f
commit a8d2a3a87c
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file

@ -274,7 +274,6 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
// which would result in the wrong profile being selected and the wrong icon being
// permanently attached to the terminal.
if (!this.shellLaunchConfig.executable && !workbenchEnvironmentService.remoteAuthority) {
// TODO: Icon flashes white first
this._terminalProfileResolverService.resolveIcon(this._shellLaunchConfig, OS);
}

2
src/vs/workbench/contrib/terminal/browser/terminalProfileResolverService.ts
View file

@ -119,7 +119,7 @@ export abstract class BaseTerminalProfileResolverService implements ITerminalPro
shellLaunchConfig.name = resolvedProfile.profileName;
}
// TODO: Verify
// Apply the color
shellLaunchConfig.color = resolvedProfile.color;
// Resolve useShellEnvironment based on the setting if it's not set