development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-12 22:37:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

add logging when async event delivery stops, (#172901)

Browse source 
#164841
This commit is contained in:
Johannes Rieken 2023-01-31 12:04:32 +01:00 committed by GitHub
parent 4ebd837022
commit a8b389f38b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/vs/workbench/api/common/extHostDocumentSaveParticipant.ts
View file

@ -50,22 +50,20 @@ export class ExtHostDocumentSaveParticipant implements ExtHostDocumentSavePartic
async $participateInSave(data: UriComponents, reason: SaveReason): Promise<boolean[]> {
const resource = URI.revive(data);
let didTimeout = false;
const didTimeoutHandle = setTimeout(() => didTimeout = true, this._thresholds.timeout);
const deadline = Date.now() + this._thresholds.timeout;
const results: boolean[] = [];
try {
for (const listener of [...this._callbacks]) { // copy to prevent concurrent modifications
if (didTimeout) {
// timeout - no more listeners
break;
}
const document = this._documents.getDocument(resource);
const success = await this._deliverEventAsyncAndBlameBadListeners(listener, <any>{ document, reason: TextDocumentSaveReason.to(reason) });
results.push(success);
const listeners = [...this._callbacks]; // copy to prevent concurrent modifications
for (let i = 0; i < listeners.length; i++) {
if (Date.now() > deadline) {
// timeout - no more listeners
this._logService.warn(`onWillSaveTextDocument: STOPPING event delivery because overall timeout (${this._thresholds.timeout}ms) has been execeeded. Listeners from these extensions will be SKIPPED: ${listeners.slice(i).map(l => l[2].identifier.value).join(', ')}`);
break;
}
} finally {
clearTimeout(didTimeoutHandle);
const listener = listeners[i];
const document = this._documents.getDocument(resource);
const success = await this._deliverEventAsyncAndBlameBadListeners(listener, <any>{ document, reason: TextDocumentSaveReason.to(reason) });
results.push(success);
}
return results;
}
@ -91,7 +89,7 @@ export class ExtHostDocumentSaveParticipant implements ExtHostDocumentSavePartic
this._badListeners.set(listener, !errors ? 1 : errors + 1);
if (typeof errors === 'number' && errors > this._thresholds.errors) {
this._logService.info(`onWillSaveTextDocument-listener from extension '${extension.identifier.value}' will now be IGNORED because of timeouts and/or errors`);
this._logService.warn(`onWillSaveTextDocument-listener from extension '${extension.identifier.value}' will now be IGNORED because of timeouts and/or errors`);
}
}
return false;