From a68bfa3846d789d632fd14b0d712497173c2a548 Mon Sep 17 00:00:00 2001 From: Pine Wu Date: Fri, 28 Feb 2020 11:56:25 -0800 Subject: [PATCH] Add back languages/css test. Fix #90538 --- test/smoke/src/areas/languages/css.test.ts | 43 ++++++++++++++++++++++ test/smoke/src/main.ts | 2 + 2 files changed, 45 insertions(+) create mode 100644 test/smoke/src/areas/languages/css.test.ts diff --git a/test/smoke/src/areas/languages/css.test.ts b/test/smoke/src/areas/languages/css.test.ts new file mode 100644 index 00000000000..02daa15c7b9 --- /dev/null +++ b/test/smoke/src/areas/languages/css.test.ts @@ -0,0 +1,43 @@ +/*--------------------------------------------------------------------------------------------- + * Copyright (c) Microsoft Corporation. All rights reserved. + * Licensed under the MIT License. See License.txt in the project root for license information. + *--------------------------------------------------------------------------------------------*/ + +import { Application, ProblemSeverity, Problems } from '../../../../automation'; + +export function setup() { + describe('Languages - CSS', () => { + it('verifies quick outline', async function () { + const app = this.app as Application; + await app.workbench.quickopen.openFile('style.css'); + + await app.workbench.quickopen.openQuickOutline(); + await app.workbench.quickopen.waitForQuickOpenElements(names => names.length === 2); + }); + + it('verifies warnings for the empty rule', async function () { + const app = this.app as Application; + await app.workbench.quickopen.openFile('style.css'); + await app.workbench.editor.waitForTypeInEditor('style.css', '.foo{}'); + + await app.code.waitForElement(Problems.getSelectorInEditor(ProblemSeverity.WARNING)); + + await app.workbench.problems.showProblemsView(); + await app.code.waitForElement(Problems.getSelectorInProblemsView(ProblemSeverity.WARNING)); + await app.workbench.problems.hideProblemsView(); + }); + + it('verifies that warning becomes an error once setting changed', async function () { + const app = this.app as Application; + await app.workbench.settingsEditor.addUserSetting('css.lint.emptyRules', '"error"'); + await app.workbench.quickopen.openFile('style.css'); + + await app.code.waitForElement(Problems.getSelectorInEditor(ProblemSeverity.ERROR)); + + const problems = new Problems(app.code); + await problems.showProblemsView(); + await app.code.waitForElement(Problems.getSelectorInProblemsView(ProblemSeverity.ERROR)); + await problems.hideProblemsView(); + }); + }); +} diff --git a/test/smoke/src/main.ts b/test/smoke/src/main.ts index fc1f4e5569f..f4d51dba717 100644 --- a/test/smoke/src/main.ts +++ b/test/smoke/src/main.ts @@ -25,6 +25,7 @@ import { setup as setupDataMigrationTests } from './areas/workbench/data-migrati import { setup as setupDataLossTests } from './areas/workbench/data-loss.test'; import { setup as setupDataPreferencesTests } from './areas/preferences/preferences.test'; import { setup as setupDataSearchTests } from './areas/search/search.test'; +import { setup as setupDataLanguagesTests } from './areas/languages/css.test'; import { setup as setupDataEditorTests } from './areas/editor/editor.test'; import { setup as setupDataStatusbarTests } from './areas/statusbar/statusbar.test'; import { setup as setupDataExtensionTests } from './areas/extensions/extensions.test'; @@ -301,6 +302,7 @@ describe(`VSCode Smoke Tests (${opts.web ? 'Web' : 'Electron'})`, () => { if (!opts.web) { setupDataLossTests(); } if (!opts.web) { setupDataPreferencesTests(); } setupDataSearchTests(); + setupDataLanguagesTests(); setupDataEditorTests(); setupDataStatusbarTests(!!opts.web); if (!opts.web) { setupDataExtensionTests(); }