development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix actionbar a11y issue #140203

Browse source
This commit is contained in:
Raymond Zhao 2022-02-16 11:32:36 -08:00
parent f932fd6ae4
commit a4b8e07f92
No known key found for this signature in database
GPG key ID: D36E5FCE46B63B58
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vs/base/browser/ui/actionbar/actionbar.ts
View file

@ -221,6 +221,14 @@ export class ActionBar extends Disposable implements IActionRunner {
container.appendChild(this.domNode);
}
private refreshRole(): void {
if (this.length() >= 2) {
this.actionsList.setAttribute('role', 'toolbar');
} else {
this.actionsList.setAttribute('role', 'presentation');
}
}
setAriaLabel(label: string): void {
if (label) {
this.actionsList.setAttribute('aria-label', label);
@ -350,6 +358,7 @@ export class ActionBar extends Disposable implements IActionRunner {
// After a clear actions might be re-added to simply toggle some actions. We should preserve focus #97128
this.focus(this.focusedItem);
}
this.refreshRole();
}
getWidth(index: number): number {
@ -379,6 +388,7 @@ export class ActionBar extends Disposable implements IActionRunner {
this.actionsList.removeChild(this.actionsList.childNodes[index]);
dispose(this.viewItems.splice(index, 1));
this._actionIds.splice(index, 1);
this.refreshRole();
}
}
@ -387,6 +397,7 @@ export class ActionBar extends Disposable implements IActionRunner {
this.viewItems = [];
this._actionIds = [];
DOM.clearNode(this.actionsList);
this.refreshRole();
}
length(): number {