development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-04 02:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #206010 from microsoft/merogge/setting-removal

Browse source 
remove alert, audio cue settings after migration
This commit is contained in:
Megan Rogge 2024-02-22 10:58:52 -08:00 committed by GitHub
parent 9c05ffbbbd a6671b6ce4
commit a3ab3b418e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts
View file

@ -834,6 +834,7 @@ Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMi
announcement = announcement ? 'auto' : 'off';
}
}
configurationKeyValuePairs.push([`${item.legacySoundSettingsKey}`, { value: undefined }]);
configurationKeyValuePairs.push([`${item.settingsKey}`, { value: announcement !== undefined ? { announcement, sound } : { sound } }]);
return configurationKeyValuePairs;
}
@ -844,11 +845,13 @@ Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMi
key: item.legacyAnnouncementSettingsKey!,
migrateFn: (announcement, accessor) => {
const configurationKeyValuePairs: ConfigurationKeyValuePairs = [];
const sound = accessor(item.legacySoundSettingsKey);
const sound = accessor(item.settingsKey)?.sound || accessor(item.legacySoundSettingsKey);
if (announcement !== undefined && typeof announcement !== 'string') {
announcement = announcement ? 'auto' : 'off';
}
configurationKeyValuePairs.push([`${item.settingsKey}`, { value: announcement !== undefined ? { announcement, sound } : { sound } }]);
configurationKeyValuePairs.push([`${item.legacyAnnouncementSettingsKey}`, { value: undefined }]);
configurationKeyValuePairs.push([`${item.legacySoundSettingsKey}`, { value: undefined }]);
return configurationKeyValuePairs;
}
})));