development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

speech - fix telemetry props (#206993)

Browse source
This commit is contained in:
Benjamin Pasero 2024-03-06 20:26:43 +01:00 committed by GitHub
parent 9b44bc28ca
commit a381c88fd3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/browser/parts/notifications/notificationsCommands.ts
View file

@ -354,7 +354,7 @@ type NotificationActionMetricsClassification = {
id: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The identifier of the action that was run from a notification.' };
actionLabel: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The label of the action that was run from a notification.' };
source: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The source of the notification where an action was run.' };
silent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the notification where an action was run is silent or not.' };
silent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the notification where an action was run is silent or not.' };
owner: 'bpasero';
comment: 'Tracks when actions are fired from notifcations and how they were fired.';
};

2
src/vs/workbench/browser/parts/notifications/notificationsTelemetry.ts
View file

@ -17,7 +17,7 @@ export interface NotificationMetrics {
export type NotificationMetricsClassification = {
id: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The identifier of the source of the notification.' };
silent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the notification is silent or not.' };
silent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether the notification is silent or not.' };
source?: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The source of the notification.' };
owner: 'bpasero';
comment: 'Helps us gain insights to what notifications are being shown, how many, and if they are silent or not.';

20
src/vs/workbench/contrib/speech/browser/speechService.ts
View file

@ -99,19 +99,19 @@ export class SpeechService extends Disposable implements ISpeechService {
type SpeechToTextSessionClassification = {
owner: 'bpasero';
comment: 'An event that fires when a speech to text session is created';
context: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Context of the session.' };
duration: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Duration of the session.' };
recognized: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'If speech was recognized.' };
context: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Context of the session.' };
sessionDuration: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Duration of the session.' };
sessionRecognized: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'If speech was recognized.' };
};
type SpeechToTextSessionEvent = {
context: string;
duration: number;
recognized: boolean;
sessionDuration: number;
sessionRecognized: boolean;
};
this.telemetryService.publicLog2<SpeechToTextSessionEvent, SpeechToTextSessionClassification>('speechToTextSession', {
context,
duration: Date.now() - sessionStart,
recognized: sessionRecognized
sessionDuration: Date.now() - sessionStart,
sessionRecognized
});
}
@ -204,13 +204,13 @@ export class SpeechService extends Disposable implements ISpeechService {
type KeywordRecognitionClassification = {
owner: 'bpasero';
comment: 'An event that fires when a speech keyword detection is started';
recognized: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'If the keyword was recognized.' };
keywordRecognized: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'If the keyword was recognized.' };
};
type KeywordRecognitionEvent = {
recognized: boolean;
keywordRecognized: boolean;
};
this.telemetryService.publicLog2<KeywordRecognitionEvent, KeywordRecognitionClassification>('keywordRecognition', {
recognized: status === KeywordRecognitionStatus.Recognized
keywordRecognized: status === KeywordRecognitionStatus.Recognized
});
return status;

2
src/vs/workbench/services/auxiliaryWindow/browser/auxiliaryWindowService.ts
View file

@ -229,7 +229,7 @@ export class BrowserAuxiliaryWindowService extends Disposable implements IAuxili
type AuxiliaryWindowClassification = {
owner: 'bpasero';
comment: 'An event that fires when an auxiliary window is opened';
bounds: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Has window bounds provided.' };
bounds: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Has window bounds provided.' };
};
type AuxiliaryWindowOpenEvent = {
bounds: boolean;