development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #180826 (#183962)

Browse source
This commit is contained in:
Sandeep Somavarapu 2023-05-31 17:28:39 +02:00 committed by GitHub
parent a8ef81ebbd
commit 9ef31ac37a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/vs/workbench/contrib/extensions/browser/fileBasedRecommendations.ts
View file

@ -151,16 +151,24 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
this._register(disposableTimeout(() => this.promptRecommendations(uri, model), 0));
}
private promptRecommendations(uri: URI, model: ITextModel): void {
if (this.promptImportantRecommendations(uri, model)) {
return;
}
this.promptRecommendedExtensionForFileExtension(uri, extname(uri).toLowerCase());
}
/**
* Prompt the user to either install the recommended extension for the file type in the current editor model
* or prompt to search the marketplace if it has extensions that can support the file type
*/
private promptRecommendations(uri: URI, model: ITextModel, extensionRecommendations?: IStringDictionary<IFileOpenCondition[]>): void {
private promptImportantRecommendations(uri: URI, model: ITextModel, extensionRecommendations?: IStringDictionary<IFileOpenCondition[]>): boolean {
const pattern = extname(uri).toLowerCase();
extensionRecommendations = extensionRecommendations ?? this.recommendationsByPattern.get(pattern) ?? this.fileOpenRecommendations;
const extensionRecommendationEntries = Object.entries(extensionRecommendations);
if (extensionRecommendationEntries.length === 0) {
return;
return false;
}
const processedPathGlobs = new Map<string, boolean>();
@ -246,10 +254,6 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
}
}
if (Object.keys(matchedRecommendations).length) {
this.promptFromRecommendations(uri, model, matchedRecommendations);
}
this.recommendationsByPattern.set(pattern, recommendationsByPattern);
if (Object.keys(unmatchedRecommendations).length) {
if (listenOnLanguageChange) {
@ -258,7 +262,7 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
// re-schedule this bit of the operation to be off the critical path - in case glob-match is slow
disposables.add(disposableTimeout(() => {
if (!disposables.isDisposed) {
this.promptRecommendations(uri, model, unmatchedRecommendations);
this.promptImportantRecommendations(uri, model, unmatchedRecommendations);
disposables.dispose();
}
}, 0));
@ -266,6 +270,13 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
disposables.add(model.onWillDispose(() => disposables.dispose()));
}
}
if (Object.keys(matchedRecommendations).length) {
this.promptFromRecommendations(uri, model, matchedRecommendations);
return true;
}
return false;
}
private promptFromRecommendations(uri: URI, model: ITextModel, extensionRecommendations: IStringDictionary<IFileOpenCondition[]>): void {
@ -304,8 +315,6 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "{0} language", languageName) : basename(uri), language, [...importantRecommendations])) {
return;
}
this.promptRecommendedExtensionForFileExtension(uri, extname(uri).toLowerCase());
}
private promptRecommendedExtensionForFileType(name: string, language: string, recommendations: string[]): boolean {