development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-04 02:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix type ahead issue in relaunched terminals

Browse source 
Phantom characters were showing up because type ahead was installing a
second onBeforeProcessData listener. The root cause was a refactor to
move and encapsulate the relaunching logic/concept inside TerminalProcessManager.

Fixes #118804

Co-authored-by: Megan Rogge <merogge@microsoft.com>
This commit is contained in:
Daniel Imms 2021-03-16 10:51:40 -07:00
parent 7243e13db1
commit 9ed0aa6c91
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file

@ -1167,7 +1167,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
this._processManager.relaunch(this._shellLaunchConfig, this._cols, this._rows, this._accessibilityService.isScreenReaderOptimized(), reset);
this._xtermTypeAhead?.reset(this._processManager);
this._xtermTypeAhead?.reset();
}
@debounce(1000)

4
src/vs/workbench/contrib/terminal/browser/terminalTypeAheadAddon.ts
View file

@ -1330,10 +1330,8 @@ export class TypeAheadAddon extends Disposable implements ITerminalAddon {
}));
}
public reset(processManager: ITerminalProcessManager) {
public reset() {
this.lastRow = undefined;
this.processManager = processManager;
this._register(this.processManager.onBeforeProcessData(e => this.onBeforeProcessData(e)));
}
private deferClearingPredictions() {