development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-30 21:06:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

Just simple object, no need for Map

Browse source
This commit is contained in:
Pine Wu 2019-08-20 17:58:35 -07:00
parent 62461ec4af
commit 9ecd1be8c1
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/vs/editor/browser/services/openerService.ts
View file

@ -21,7 +21,7 @@ export class OpenerService extends Disposable implements IOpenerService {
_serviceBrand!: ServiceIdentifier<any>;
private readonly _opener = new LinkedList<IOpener>();
private readonly _validatorMap = new Map<string, LinkedList<IValidator>>();
private readonly _validatorMap: { [k: string]: LinkedList<IValidator> } = {};
constructor(
@ICodeEditorService private readonly _editorService: ICodeEditorService,
@ -36,10 +36,10 @@ export class OpenerService extends Disposable implements IOpenerService {
}
registerValidator(uriScheme: string, validator: IValidator): IDisposable {
if (!this._validatorMap.has(uriScheme)) {
this._validatorMap.set(uriScheme, new LinkedList<IValidator>());
if (!this._validatorMap[uriScheme]) {
this._validatorMap[uriScheme] = new LinkedList<IValidator>();
}
const remove = this._validatorMap.get(uriScheme)!.push(validator);
const remove = this._validatorMap[uriScheme].push(validator);
return { dispose: remove };
}
@ -50,8 +50,8 @@ export class OpenerService extends Disposable implements IOpenerService {
}
// check with contributed validators
if (this._validatorMap.has(resource.scheme)) {
const validators = this._validatorMap.get(resource.scheme)!.toArray();
if (this._validatorMap[resource.scheme]) {
const validators = this._validatorMap[resource.scheme].toArray();
for (const validator of validators) {
if (!(await validator.shouldOpen(resource))) {
return false;
@ -132,6 +132,8 @@ export class OpenerService extends Disposable implements IOpenerService {
}
dispose() {
this._validatorMap.clear();
for (let key in this._validatorMap) {
delete this._validatorMap[key];
}
}
}