development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-01 08:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove session if it is being replaced (#212504)

Browse source 
A bug that has probably existed for quite a while... if we are replacing a session, we should say the old session is removed.
This commit is contained in:
Tyler James Leonhardt 2024-05-11 05:49:03 -07:00 committed by GitHub
parent bbc0159f43
commit 9d4274e559
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
extensions/github-authentication/src/github.ts
View file

@ -306,14 +306,15 @@ export class GitHubAuthenticationProvider implements vscode.AuthenticationProvid
this.afterSessionLoad(session); this.afterSessionLoad(session);
const sessionIndex = sessions.findIndex(s => s.id === session.id || arrayEquals([...s.scopes].sort(), sortedScopes)); const sessionIndex = sessions.findIndex(s => s.id === session.id || arrayEquals([...s.scopes].sort(), sortedScopes));
const removed = new Array<vscode.AuthenticationSession>();
if (sessionIndex > -1) { if (sessionIndex > -1) {
sessions.splice(sessionIndex, 1, session); removed.push(...sessions.splice(sessionIndex, 1, session));
} else { } else {
sessions.push(session); sessions.push(session);
} }
await this.storeSessions(sessions); await this.storeSessions(sessions);
this._sessionChangeEmitter.fire({ added: [session], removed: [], changed: [] }); this._sessionChangeEmitter.fire({ added: [session], removed, changed: [] });
this._logger.info('Login success!'); this._logger.info('Login success!');