mirror of
https://github.com/Microsoft/vscode
synced 2024-09-13 13:46:13 +00:00
file working copy - update todos
This commit is contained in:
parent
6bea69b5e2
commit
9cd4712b35
2
src/bootstrap-node.js
vendored
2
src/bootstrap-node.js
vendored
|
@ -10,7 +10,7 @@
|
|||
// - Windows: call `process.chdir()` to always set application folder as cwd
|
||||
// - Posix: allow to change the current working dir via `VSCODE_CWD` if defined
|
||||
// - all OS: store the `process.cwd()` inside `VSCODE_CWD` for consistent lookups
|
||||
// // TODO@bpasero revisit if chdir() on Windows is needed in the future still
|
||||
// TODO@bpasero revisit if chdir() on Windows is needed in the future still
|
||||
function setupCurrentWorkingDirectory() {
|
||||
const path = require('path');
|
||||
|
||||
|
|
|
@ -66,8 +66,6 @@ export interface IFileWorkingCopyModel {
|
|||
* Snapshots the model's current content for writing. This must include
|
||||
* any changes that were made to the model that are in memory.
|
||||
*
|
||||
* TODO@bpasero could this method return sync and not promise?
|
||||
*
|
||||
* @param token support for cancellation
|
||||
*/
|
||||
snapshot(token: CancellationToken): Promise<VSBufferReadableStream>;
|
||||
|
@ -89,7 +87,7 @@ export interface IFileWorkingCopyModel {
|
|||
* case of undo-redo.
|
||||
*
|
||||
* TODO@bpasero should find a better name here maybe together
|
||||
* with the pushStackElement concept since this is around
|
||||
* with the `pushStackElement` concept since this is around
|
||||
* undo/redo?
|
||||
*/
|
||||
getAlternativeVersionId(): number;
|
||||
|
@ -102,7 +100,9 @@ export interface IFileWorkingCopyModel {
|
|||
* save is triggered so that the user can always undo back
|
||||
* to the state before saving.
|
||||
*
|
||||
* TODO@bpasero rename to beforeSave()?
|
||||
* TODO@bpasero should find a better name here maybe together
|
||||
* with the `getAlternativeVersionId` concept since this is around
|
||||
* undo/redo?
|
||||
*/
|
||||
pushStackElement(): void;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue