development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong notebook cell drag offset with global toolbar active

Browse source
This commit is contained in:
Rob Lourens 2022-03-11 11:44:22 -08:00
parent 420e872464
commit 9925da41e4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/contrib/notebook/browser/view/cellParts/cellDnd.ts
View file

@ -44,11 +44,11 @@ export class CellDragAndDropController extends Disposable {
constructor(
private readonly notebookEditor: INotebookEditorDelegate,
insertionIndicatorContainer: HTMLElement
private readonly notebookListContainer: HTMLElement
) {
super();
this.listInsertionIndicator = DOM.append(insertionIndicatorContainer, $('.cell-list-insertion-indicator'));
this.listInsertionIndicator = DOM.append(notebookListContainer, $('.cell-list-insertion-indicator'));
this._register(DOM.addDisposableListener(document.body, DOM.EventType.DRAG_START, this.onGlobalDragStart.bind(this), true));
this._register(DOM.addDisposableListener(document.body, DOM.EventType.DRAG_END, this.onGlobalDragEnd.bind(this), true));
@ -110,7 +110,7 @@ export class CellDragAndDropController extends Disposable {
}
private toCellDragEvent(event: DragEvent): CellDragEvent | undefined {
const targetTop = this.notebookEditor.getDomNode().getBoundingClientRect().top;
const targetTop = this.notebookListContainer.getBoundingClientRect().top;
const dragOffset = this.list.scrollTop + event.clientY - targetTop;
const draggedOverCell = this.list.elementAt(dragOffset);
if (!draggedOverCell) {