development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-07-07 19:50:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Observable logging improvement (#215759)

Browse Source
This commit is contained in:
Henning Dieterichs 2024-06-16 18:16:40 +02:00 committed by GitHub
parent 35ac2d01a6
commit 937c8c0c94
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/base/common/observableInternal/autorun.ts
View File

@ -154,7 +154,7 @@ export class AutorunObserver<TChangeSummary = any> implements IObserver, IReader
}
constructor(
private readonly _debugNameData: DebugNameData,
public readonly _debugNameData: DebugNameData,
public readonly _runFn: (reader: IReader, changeSummary: TChangeSummary) => void,
private readonly createChangeSummary: (() => TChangeSummary) | undefined,
private readonly _handleChange: ((context: IChangeContext, summary: TChangeSummary) => boolean) | undefined,

2
src/vs/base/common/observableInternal/derived.ts
View File

@ -192,7 +192,7 @@ export class Derived<T, TChangeSummary = any> extends BaseObservable<T, void> im
}
constructor(
private readonly _debugNameData: DebugNameData,
public readonly _debugNameData: DebugNameData,
public readonly _computeFn: (reader: IReader, changeSummary: TChangeSummary) => T,
private readonly createChangeSummary: (() => TChangeSummary) | undefined,
private readonly _handleChange: ((context: IChangeContext, summary: TChangeSummary) => boolean) | undefined,

4
src/vs/base/common/observableInternal/logging.ts
View File

@ -114,7 +114,7 @@ export class ConsoleObservableLogger implements IObservableLogger {
styled(derived.debugName, { color: 'BlueViolet' }),
...this.formatInfo(info),
this.formatChanges(changedObservables),
{ data: [{ fn: derived._computeFn }] }
{ data: [{ fn: derived._debugNameData.referenceFn ?? derived._computeFn }] }
]));
changedObservables.clear();
}
@ -143,7 +143,7 @@ export class ConsoleObservableLogger implements IObservableLogger {
formatKind('autorun'),
styled(autorun.debugName, { color: 'BlueViolet' }),
this.formatChanges(changedObservables),
{ data: [{ fn: autorun._runFn }] }
{ data: [{ fn: autorun._debugNameData.referenceFn ?? autorun._runFn }] }
]));
changedObservables.clear();
this.indentation++;