development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Also ignore star checkboxes (#151029)

Browse source 
Fixes #150672

This makes our md link detection also ignore checkboxes like `* [x]` instead of just `- [x]`
This commit is contained in:
Matt Bierner 2022-06-01 14:23:29 -07:00 committed by GitHub
parent 0715386207
commit 9302343e8e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/markdown-language-features/src/languageFeatures/documentLinkProvider.ts
View file

@ -357,7 +357,7 @@ export class MdLinkProvider implements vscode.DocumentLinkProvider {
linkStart = document.positionAt(offset);
const line = document.lineAt(linkStart.line);
// See if link looks like a checkbox
const checkboxMatch = line.text.match(/^\s*\-\s*\[x\]/i);
const checkboxMatch = line.text.match(/^\s*[\-\*]\s*\[x\]/i);
if (checkboxMatch && linkStart.character <= checkboxMatch[0].length) {
continue;
}

7
extensions/markdown-language-features/src/test/documentLinkProvider.test.ts
View file

@ -318,12 +318,15 @@ suite('markdown.DocumentLinkProvider', () => {
const links = await getLinksForFile(joinLines(
'- [x]',
'- [X]',
'- []',
'- [ ]',
'* [x]',
'* [X]',
'* [ ]',
``,
`[x]: http://example.com`
));
assert.strictEqual(links.length, 1);
assertRangeEqual(links[0].range, new vscode.Range(4, 5, 4, 23));
assertRangeEqual(links[0].range, new vscode.Range(7, 5, 7, 23));
});