development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support copying non-pngs and wait for focus to avoid race conditions (#180322)

Browse source 
* Support copying non-pngs and wait for focus to avoid race conditions

* Remove the temporary canvas element after copying

* Update to place entire canvas creation inside promise.

* Increasing to 5 retries 20ms apart
This commit is contained in:
Anthony Stewart 2023-04-20 20:51:41 +02:00 committed by GitHub
parent b9e657dbf5
commit 92d528bbd3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
extensions/media-preview/media/imagePreview.js
View file

@ -354,10 +354,27 @@
copyImage();
});
async function copyImage() {
async function copyImage(retries = 5) {
if (!document.hasFocus() && retries > 0) {
// copyImage is called at the same time as webview.reveal, which means this function is running whilst the webview is gaining focus.
// Since navigator.clipboard.write requires the document to be focused, we need to wait for focus.
// We cannot use a listener, as there is a high chance the focus is gained during the setup of the listener resulting in us missing it.
setTimeout(() => { copyImage(retries - 1); }, 20);
return;
}
try {
await navigator.clipboard.write([new ClipboardItem({
'image/png': fetch(image.src).then(request => request.blob())
'image/png': new Promise((resolve, reject) => {
const canvas = document.createElement('canvas');
canvas.width = image.naturalWidth;
canvas.height = image.naturalHeight;
canvas.getContext('2d').drawImage(image, 0, 0);
canvas.toBlob((blob) => {
resolve(blob);
canvas.remove();
}, 'image/png');
})
})]);
} catch (e) {
console.error(e);