development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix opening select boxes (#214348)

Browse source 
* Fix opening select boxes

This fixes a regression caused by #213465

Closes #214303
Closes #214345

* Fix another regression caused by #213465

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
This commit is contained in:
Remco Haszing 2024-06-05 20:49:43 +02:00 committed by GitHub
parent 7cd1f1ce4e
commit 9111dec272
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
View file

@ -609,8 +609,8 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
this._dropDownPosition = AnchorPosition.ABOVE;
this.selectDropDownListContainer.remove();
this.selectionDetailsPane.remove();
this.selectionDetailsPane.remove();
this.selectDropDownListContainer.remove();
this.selectDropDownContainer.appendChild(this.selectionDetailsPane);
this.selectDropDownContainer.appendChild(this.selectDropDownListContainer);
this.selectionDetailsPane.classList.remove('border-top');
this.selectionDetailsPane.classList.add('border-bottom');
@ -619,8 +619,8 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
this._dropDownPosition = AnchorPosition.BELOW;
this.selectDropDownListContainer.remove();
this.selectionDetailsPane.remove();
this.selectDropDownListContainer.remove();
this.selectionDetailsPane.remove();
this.selectDropDownContainer.appendChild(this.selectDropDownListContainer);
this.selectDropDownContainer.appendChild(this.selectionDetailsPane);
this.selectionDetailsPane.classList.remove('border-bottom');
this.selectionDetailsPane.classList.add('border-top');

2
src/vs/workbench/contrib/splash/browser/partsSplash.ts
View file

@ -110,6 +110,6 @@ export class PartsSplash {
// remove initial colors
const defaultStyles = mainWindow.document.head.getElementsByClassName('initialShellColors');
defaultStyles?.[0].remove();
defaultStyles[0]?.remove();
}
}