development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-19 18:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

No Prevent Default For Navigation Mouse Buttons On github/vscode.dev (fix #176638) (#177203)

Browse source
This commit is contained in:
Benjamin Pasero 2023-03-15 13:35:33 +01:00 committed by GitHub
parent 2c3a648d88
commit 8fc95494ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/vs/workbench/services/history/browser/historyService.ts
View file

@ -111,7 +111,8 @@ export class HistoryService extends Disposable implements IHistoryService {
mouseBackForwardSupportListener.clear();
if (this.configurationService.getValue(HistoryService.MOUSE_NAVIGATION_SETTING)) {
mouseBackForwardSupportListener.add(addDisposableListener(this.layoutService.container, EventType.MOUSE_DOWN, e => this.onMouseDown(e)));
mouseBackForwardSupportListener.add(addDisposableListener(this.layoutService.container, EventType.MOUSE_DOWN, e => this.onMouseDownOrUp(e, true)));
mouseBackForwardSupportListener.add(addDisposableListener(this.layoutService.container, EventType.MOUSE_UP, e => this.onMouseDownOrUp(e, false)));
}
};
@ -124,17 +125,26 @@ export class HistoryService extends Disposable implements IHistoryService {
handleMouseBackForwardSupport();
}
private onMouseDown(event: MouseEvent): void {
private onMouseDownOrUp(event: MouseEvent, isMouseDown: boolean): void {
// Support to navigate in history when mouse buttons 4/5 are pressed
// We want to trigger this on mouse down for a faster experience
// but we also need to prevent mouse up from triggering the default
// which is to navigate in the browser history.
switch (event.button) {
case 3:
EventHelper.stop(event);
this.goBack();
if (isMouseDown) {
this.goBack();
}
break;
case 4:
EventHelper.stop(event);
this.goForward();
if (isMouseDown) {
this.goForward();
}
break;
}
}