development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove custom editor support for data uris

Browse source 
For #85203. Data uris are no longer used by VS Code core
This commit is contained in:
Matt Bierner 2019-11-20 21:35:29 -08:00
parent 61cf4155b3
commit 8fa16bd74f
3 changed files with 1 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extensions/image-preview/package.json
View file

@ -30,7 +30,6 @@
"selector": [
{
"filenamePattern": "*.{jpg,jpe,jpeg,png,bmp,gif,ico,webp}",
"mime": "image/*"
}
]
}

16
src/vs/workbench/contrib/customEditor/browser/customEditors.ts
View file

@ -7,8 +7,7 @@ import { coalesce, distinct, find, mergeSort } from 'vs/base/common/arrays';
import * as glob from 'vs/base/common/glob';
import { Lazy } from 'vs/base/common/lazy';
import { Disposable, UnownedDisposable } from 'vs/base/common/lifecycle';
import { Schemas } from 'vs/base/common/network';
import { basename, DataUri, isEqual } from 'vs/base/common/resources';
import { basename, isEqual } from 'vs/base/common/resources';
import { URI } from 'vs/base/common/uri';
import { generateUuid } from 'vs/base/common/uuid';
import * as nls from 'vs/nls';
@ -31,7 +30,6 @@ import { IEditorGroup } from 'vs/workbench/services/editor/common/editorGroupsSe
import { IEditorService, IOpenEditorOverride } from 'vs/workbench/services/editor/common/editorService';
import { IWorkingCopyService } from 'vs/workbench/services/workingCopy/common/workingCopyService';
import { CustomFileEditorInput } from './customEditorInput';
const defaultEditorId = 'default';
const defaultEditorInfo: CustomEditorInfo = {
@ -408,18 +406,6 @@ function priorityToRank(priority: CustomEditorPriority): number {
}
function matches(selector: CustomEditorSelector, resource: URI): boolean {
if (resource.scheme === Schemas.data) {
if (!selector.mime) {
return false;
}
const metadata = DataUri.parseMetaData(resource);
const mime = metadata.get(DataUri.META_DATA_MIME);
if (!mime) {
return false;
}
return glob.match(selector.mime, mime.toLowerCase());
}
if (selector.filenamePattern) {
if (glob.match(selector.filenamePattern.toLowerCase(), basename(resource).toLowerCase())) {
return true;

1
src/vs/workbench/contrib/customEditor/common/customEditor.ts
View file

@ -70,7 +70,6 @@ export const enum CustomEditorPriority {
export interface CustomEditorSelector {
readonly filenamePattern?: string;
readonly mime?: string;
}
export interface CustomEditorInfo {