development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add cursorSmoothCaretAnimation: explicit (#169113)

Browse source 
Fixes #168857: Add `cursorSmoothCaretAnimation: explicit`
This commit is contained in:
Alexandru Dima 2022-12-14 11:23:26 +01:00 committed by GitHub
parent ed36fc536a
commit 8b939ad54b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/editor/browser/config/migrateOptions.ts
View file

@ -90,6 +90,7 @@ registerSimpleEditorSettingMigration('parameterHints', [[true, { enabled: true }
registerSimpleEditorSettingMigration('autoIndent', [[false, 'advanced'], [true, 'full']]);
registerSimpleEditorSettingMigration('matchBrackets', [[true, 'always'], [false, 'never']]);
registerSimpleEditorSettingMigration('renderFinalNewline', [[true, 'on'], [false, 'off']]);
registerSimpleEditorSettingMigration('cursorSmoothCaretAnimation', [[true, 'on'], [false, 'off']]);
registerEditorSettingMigration('autoClosingBrackets', (value, read, write) => {
if (value === false) {

4
src/vs/editor/browser/viewParts/viewCursors/viewCursors.ts
View file

@ -25,7 +25,7 @@ export class ViewCursors extends ViewPart {
private _readOnly: boolean;
private _cursorBlinking: TextEditorCursorBlinkingStyle;
private _cursorStyle: TextEditorCursorStyle;
private _cursorSmoothCaretAnimation: boolean;
private _cursorSmoothCaretAnimation: 'off' | 'explicit' | 'on';
private _selectionIsEmpty: boolean;
private _isComposingInput: boolean;
@ -117,7 +117,7 @@ export class ViewCursors extends ViewPart {
private _onCursorPositionChanged(position: Position, secondaryPositions: Position[], reason: CursorChangeReason): void {
const pauseAnimation = (
this._secondaryCursors.length !== secondaryPositions.length
|| reason !== CursorChangeReason.Explicit
|| (this._cursorSmoothCaretAnimation === 'explicit' && reason !== CursorChangeReason.Explicit)
);
this._primaryCursor.onCursorPositionChanged(position, pauseAnimation);
this._updateBlinking();

19
src/vs/editor/common/config/editorOptions.ts
View file

@ -214,9 +214,9 @@ export interface IEditorOptions {
mouseStyle?: 'text' | 'default' | 'copy';
/**
* Enable smooth caret animation.
* Defaults to false.
* Defaults to 'off'.
*/
cursorSmoothCaretAnimation?: boolean;
cursorSmoothCaretAnimation?: 'off' | 'explicit' | 'on';
/**
* Control the cursor style, either 'block' or 'line'.
* Defaults to 'line'.
@ -5014,9 +5014,18 @@ export const EditorOptions = {
_cursorBlinkingStyleFromString,
{ description: nls.localize('cursorBlinking', "Control the cursor animation style.") }
)),
cursorSmoothCaretAnimation: register(new EditorBooleanOption(
EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation', false,
{ description: nls.localize('cursorSmoothCaretAnimation', "Controls whether the smooth caret animation should be enabled.") }
cursorSmoothCaretAnimation: register(new EditorStringEnumOption(
EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation',
'off' as 'off' | 'explicit' | 'on',
['off', 'explicit', 'on'] as const,
{
enumDescriptions: [
nls.localize('cursorSmoothCaretAnimation.off', "Smooth caret animation is disabled."),
nls.localize('cursorSmoothCaretAnimation.explicit', "Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture."),
nls.localize('cursorSmoothCaretAnimation.on', "Smooth caret animation is always enabled.")
],
description: nls.localize('cursorSmoothCaretAnimation', "Controls whether the smooth caret animation should be enabled.")
}
)),
cursorStyle: register(new EditorEnumOption(
EditorOption.cursorStyle, 'cursorStyle',

6
src/vs/monaco.d.ts vendored
View file

@ -3185,9 +3185,9 @@ declare namespace monaco.editor {
mouseStyle?: 'text' | 'default' | 'copy';
/**
* Enable smooth caret animation.
* Defaults to false.
* Defaults to 'off'.
*/
cursorSmoothCaretAnimation?: boolean;
cursorSmoothCaretAnimation?: 'off' | 'explicit' | 'on';
/**
* Control the cursor style, either 'block' or 'line'.
* Defaults to 'line'.
@ -4739,7 +4739,7 @@ declare namespace monaco.editor {
contextmenu: IEditorOption<EditorOption.contextmenu, boolean>;
copyWithSyntaxHighlighting: IEditorOption<EditorOption.copyWithSyntaxHighlighting, boolean>;
cursorBlinking: IEditorOption<EditorOption.cursorBlinking, TextEditorCursorBlinkingStyle>;
cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, boolean>;
cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, 'on' | 'off' | 'explicit'>;
cursorStyle: IEditorOption<EditorOption.cursorStyle, TextEditorCursorStyle>;
cursorSurroundingLines: IEditorOption<EditorOption.cursorSurroundingLines, number>;
cursorSurroundingLinesStyle: IEditorOption<EditorOption.cursorSurroundingLinesStyle, 'default' | 'all'>;