Merge pull request #226485 from mjbvz/informal-echidna

Enable ATA on web by default again
This commit is contained in:
Matt Bierner 2024-08-23 13:30:54 -07:00 committed by GitHub
commit 89f2077c35
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions

View file

@ -1426,13 +1426,13 @@
},
"typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors": {
"type": "boolean",
"default": true,
"default": false,
"description": "%configuration.tsserver.web.projectWideIntellisense.suppressSemanticErrors%",
"scope": "window"
},
"typescript.tsserver.web.typeAcquisition.enabled": {
"type": "boolean",
"default": false,
"default": true,
"description": "%configuration.tsserver.web.typeAcquisition.enabled%",
"scope": "window"
},

View file

@ -263,11 +263,11 @@ export abstract class BaseServiceConfigurationProvider implements ServiceConfigu
}
private readWebProjectWideIntellisenseSuppressSemanticErrors(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors', true);
return this.readWebTypeAcquisition(configuration) && configuration.get<boolean>('typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors', false);
}
private readWebTypeAcquisition(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.web.typeAcquisition.enabled', false);
return configuration.get<boolean>('typescript.tsserver.web.typeAcquisition.enabled', true);
}
private readEnableRegionDiagnostics(configuration: vscode.WorkspaceConfiguration): boolean {