From 888fd835ca18a3b2668a91b404e188cd05bbcb99 Mon Sep 17 00:00:00 2001 From: aamunger Date: Thu, 17 Nov 2022 10:16:13 -0800 Subject: [PATCH] don't clean attachments for a cell that is removed --- extensions/ipynb/src/notebookAttachmentCleaner.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/ipynb/src/notebookAttachmentCleaner.ts b/extensions/ipynb/src/notebookAttachmentCleaner.ts index a72761754df..c7af81492da 100644 --- a/extensions/ipynb/src/notebookAttachmentCleaner.ts +++ b/extensions/ipynb/src/notebookAttachmentCleaner.ts @@ -187,7 +187,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider { } } - if (!objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) { + if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) { const updateMetadata: { [key: string]: any } = deepClone(cell.metadata); updateMetadata.attachments = markdownAttachmentsInUse; const metadataEdit = vscode.NotebookEdit.updateCellMetadata(cell.index, updateMetadata);