development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 17:32:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use task filter type to filter on provider

Browse source 
Fixes #78179
This commit is contained in:
Alex Ross 2019-08-06 16:15:18 +02:00
parent 6127460acc
commit 8839c0259d
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
View file

@ -502,7 +502,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
if (!this.versionAndEngineCompatible(filter)) {
return Promise.resolve<Task[]>([]);
}
return this.getGroupedTasks().then((map) => {
return this.getGroupedTasks(filter ? filter.type : undefined).then((map) => {
if (!filter || !filter.type) {
return map.all();
}
@ -1117,7 +1117,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
protected abstract getTaskSystem(): ITaskSystem;
private getGroupedTasks(): Promise<TaskMap> {
private getGroupedTasks(type?: string): Promise<TaskMap> {
return Promise.all([this.extensionService.activateByEvent('onCommand:workbench.action.tasks.runTask'), TaskDefinitionRegistry.onReady()]).then(() => {
let validTypes: IStringDictionary<boolean> = Object.create(null);
TaskDefinitionRegistry.all().forEach(definition => validTypes[definition.taskType] = true);
@ -1152,10 +1152,12 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
}
};
if (this.schemaVersion === JsonSchemaVersion.V2_0_0 && this._providers.size > 0) {
this._providers.forEach((provider) => {
counter++;
provider.provideTasks(validTypes).then(done, error);
});
for (const [handle, provider] of this._providers) {
if ((type === undefined) || (type === this._providerTypes.get(handle))) {
counter++;
provider.provideTasks(validTypes).then(done, error);
}
}
} else {
resolve(result);
}