development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix pasting image into newly created cell bug

Browse source
This commit is contained in:
Michael Lively 2022-08-17 12:17:39 -07:00
parent d37e1b9183
commit 880fda6ed9
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
extensions/ipynb/src/notebookImagePaste.ts
View file

@ -62,9 +62,17 @@ class CopyPasteEditProvider implements vscode.DocumentPasteEditProvider {
// create updated metadata for cell (prep for WorkspaceEdit) // create updated metadata for cell (prep for WorkspaceEdit)
const b64string = encodeBase64(fileDataAsUint8); const b64string = encodeBase64(fileDataAsUint8);
const startingAttachments = currentCell.metadata?.custom?.attachments; const startingAttachments = currentCell.metadata.custom?.attachments;
let metadataNotebookEdit;
if (!startingAttachments) { if (!startingAttachments) {
currentCell.metadata.custom['attachments'] = { [pasteFilename]: { 'image/png': b64string } }; if (!currentCell.metadata.custom) {
const initMetadata = { 'custom': { 'attachments': { [pasteFilename]: { 'image/png': b64string } } } };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, initMetadata);
} else {
currentCell.metadata.custom['attachments'] = { [pasteFilename]: { 'image/png': b64string } };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
}
} else { } else {
for (let appendValue = 2; pasteFilename in startingAttachments; appendValue++) { for (let appendValue = 2; pasteFilename in startingAttachments; appendValue++) {
const objEntries = Object.entries(startingAttachments[pasteFilename]); const objEntries = Object.entries(startingAttachments[pasteFilename]);
@ -76,9 +84,9 @@ class CopyPasteEditProvider implements vscode.DocumentPasteEditProvider {
} }
} }
currentCell.metadata.custom.attachments[pasteFilename] = { 'image/png': b64string }; currentCell.metadata.custom.attachments[pasteFilename] = { 'image/png': b64string };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
} }
const metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
const workspaceEdit = new vscode.WorkspaceEdit(); const workspaceEdit = new vscode.WorkspaceEdit();
if (metadataNotebookEdit) { if (metadataNotebookEdit) {
workspaceEdit.set(notebookUri, [metadataNotebookEdit]); workspaceEdit.set(notebookUri, [metadataNotebookEdit]);