mirror of
https://github.com/Microsoft/vscode
synced 2024-09-13 21:55:38 +00:00
clear diagnostics on delete, no diagnostics for IW cells (#208794)
This commit is contained in:
parent
62d83b2a75
commit
86c791ebb2
|
@ -38,14 +38,16 @@ export class CellDiagnostics extends Disposable {
|
|||
) {
|
||||
super();
|
||||
|
||||
this.updateEnabled();
|
||||
if (cell.viewType !== 'interactive') {
|
||||
this.updateEnabled();
|
||||
|
||||
this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
|
||||
this._register(configurationService.onDidChangeConfiguration((e) => {
|
||||
if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
|
||||
this.updateEnabled();
|
||||
}
|
||||
}));
|
||||
this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
|
||||
this._register(configurationService.onDidChangeConfiguration((e) => {
|
||||
if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
|
||||
this.updateEnabled();
|
||||
}
|
||||
}));
|
||||
}
|
||||
}
|
||||
|
||||
private updateEnabled() {
|
||||
|
@ -103,4 +105,9 @@ export class CellDiagnostics extends Disposable {
|
|||
};
|
||||
}
|
||||
|
||||
override dispose() {
|
||||
super.dispose();
|
||||
this.clear();
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue