development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

clear diagnostics on delete, no diagnostics for IW cells (#208794)

Browse source
This commit is contained in:
Aaron Munger 2024-03-26 08:43:28 -07:00 committed by GitHub
parent 62d83b2a75
commit 86c791ebb2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/vs/workbench/contrib/notebook/browser/contrib/cellDiagnostics/cellDiagnostics.ts
View file

@ -38,14 +38,16 @@ export class CellDiagnostics extends Disposable {
) {
super();
this.updateEnabled();
if (cell.viewType !== 'interactive') {
this.updateEnabled();
this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
this._register(configurationService.onDidChangeConfiguration((e) => {
if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
this.updateEnabled();
}
}));
this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
this._register(configurationService.onDidChangeConfiguration((e) => {
if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
this.updateEnabled();
}
}));
}
}
private updateEnabled() {
@ -103,4 +105,9 @@ export class CellDiagnostics extends Disposable {
};
}
override dispose() {
super.dispose();
this.clear();
}
}