development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't clear chat disposables too early while progressive rendering (#215907)

Browse source 
This clear() is wrong because this loop is incrementally updating content, not rerendering everything. Deleting is also not quite right because we are technically leaking when things get rerendered. But that is only the case while in the middle of streaming content, and things will always be fixed up when the response is done loading.
Fix #212853
This commit is contained in:
Rob Lourens 2024-06-16 20:47:44 -07:00 committed by GitHub
parent b49212f5cb
commit 85e9b0786c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/workbench/contrib/chat/browser/chatListRenderer.ts
View file

@ -684,7 +684,6 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
disposables.clear();
this.basicRenderElement(renderableResponse, element, index, templateData);
} else if (!isFullyRendered) {
disposables.clear();
this.renderContentReferencesIfNeeded(element, templateData, disposables);
let hasRenderedOneMarkdownBlock = false;
partsToRender.forEach((partToRender, index) => {