development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #75909

Browse source
This commit is contained in:
Benjamin Pasero 2019-06-27 11:50:12 +02:00
parent 30379ab74b
commit 84bfa21566
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
View file

@ -603,7 +603,6 @@ export class StatusbarPart extends Part implements IStatusbarService {
private doCreateStatusItem(id: string, name: string, alignment: StatusbarAlignment, priority: number = 0, ...extraClasses: string[]): HTMLElement {
const itemContainer = document.createElement('div');
itemContainer.title = name;
itemContainer.id = id;
addClass(itemContainer, 'statusbar-item');
@ -683,12 +682,12 @@ class StatusbarEntryItem extends Disposable {
}
}
// Update: Tooltip
// Update: Tooltip (on the container, because label can be disabled)
if (!this.entry || entry.tooltip !== this.entry.tooltip) {
if (entry.tooltip) {
this.labelContainer.title = entry.tooltip;
this.container.title = entry.tooltip;
} else {
delete this.labelContainer.title;
delete this.container.title;
}
}

10
test/smoke/src/areas/statusbar/statusbar.ts
View file

@ -50,15 +50,15 @@ export class StatusBar {
case StatusBarElement.PROBLEMS_STATUS:
return `${this.mainSelector} ${this.leftSelector} .octicon.octicon-error`;
case StatusBarElement.SELECTION_STATUS:
return `${this.mainSelector} ${this.rightSelector} a[title="Go to Line"]`;
return `${this.mainSelector} ${this.rightSelector}[title="Go to Line"]`;
case StatusBarElement.INDENTATION_STATUS:
return `${this.mainSelector} ${this.rightSelector} a[title="Select Indentation"]`;
return `${this.mainSelector} ${this.rightSelector}[title="Select Indentation"]`;
case StatusBarElement.ENCODING_STATUS:
return `${this.mainSelector} ${this.rightSelector} a[title="Select Encoding"]`;
return `${this.mainSelector} ${this.rightSelector}[title="Select Encoding"]`;
case StatusBarElement.EOL_STATUS:
return `${this.mainSelector} ${this.rightSelector} a[title="Select End of Line Sequence"]`;
return `${this.mainSelector} ${this.rightSelector}[title="Select End of Line Sequence"]`;
case StatusBarElement.LANGUAGE_STATUS:
return `${this.mainSelector} ${this.rightSelector} a[title="Select Language Mode"]`;
return `${this.mainSelector} ${this.rightSelector}[title="Select Language Mode"]`;
case StatusBarElement.FEEDBACK_ICON:
return `${this.mainSelector} ${this.rightSelector} .monaco-dropdown.send-feedback`;
default: