mirror of
https://github.com/Microsoft/vscode
synced 2024-10-02 09:18:59 +00:00
easy no leak test cases (#201017)
* easy no leak cases * remove unused function
This commit is contained in:
parent
9af00bdd83
commit
8371e4a567
|
@ -254,15 +254,8 @@
|
|||
"src/vs/workbench/contrib/editSessions/test/browser/editSessions.test.ts",
|
||||
"src/vs/workbench/contrib/extensions/test/common/extensionQuery.test.ts",
|
||||
"src/vs/workbench/contrib/extensions/test/electron-sandbox/extension.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/cellDnd.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/contrib/contributedStatusBarItemController.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/contrib/executionStatusBarItem.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/contrib/layoutActions.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/contrib/outputCopyTests.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/notebookBrowser.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/notebookExecutionService.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/notebookExecutionStateService.test.ts",
|
||||
"src/vs/workbench/contrib/notebook/test/browser/notebookTextModel.test.ts",
|
||||
"src/vs/workbench/contrib/snippets/test/browser/snippetFile.test.ts",
|
||||
"src/vs/workbench/contrib/snippets/test/browser/snippetsRegistry.test.ts",
|
||||
"src/vs/workbench/contrib/snippets/test/browser/snippetsRewrite.test.ts",
|
||||
|
|
|
@ -8,6 +8,7 @@ import { CellKind } from 'vs/workbench/contrib/notebook/common/notebookCommon';
|
|||
import { withTestNotebook } from 'vs/workbench/contrib/notebook/test/browser/testNotebookEditor';
|
||||
import * as assert from 'assert';
|
||||
import { ICellRange } from 'vs/workbench/contrib/notebook/common/notebookRange';
|
||||
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
|
||||
|
||||
interface IBeginningState {
|
||||
startOrder: string[];
|
||||
|
@ -46,6 +47,8 @@ async function testCellDnd(beginning: IBeginningState, dragAction: IDragAction,
|
|||
}
|
||||
|
||||
suite('cellDND', () => {
|
||||
ensureNoDisposablesAreLeakedInTestSuite();
|
||||
|
||||
test('drag 1 cell', async () => {
|
||||
await testCellDnd(
|
||||
{
|
||||
|
|
|
@ -8,6 +8,7 @@ import { CancellationToken } from 'vs/base/common/cancellation';
|
|||
import { Emitter, Event } from 'vs/base/common/event';
|
||||
import { Disposable, DisposableStore } from 'vs/base/common/lifecycle';
|
||||
import { URI } from 'vs/base/common/uri';
|
||||
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
|
||||
import { ContributedStatusBarItemController } from 'vs/workbench/contrib/notebook/browser/contrib/cellStatusBar/contributedStatusBarItemController';
|
||||
import { INotebookCellStatusBarService } from 'vs/workbench/contrib/notebook/common/notebookCellStatusBarService';
|
||||
import { CellKind, INotebookCellStatusBarItemProvider } from 'vs/workbench/contrib/notebook/common/notebookCommon';
|
||||
|
@ -20,6 +21,8 @@ suite('Notebook Statusbar', () => {
|
|||
testDisposables.clear();
|
||||
});
|
||||
|
||||
ensureNoDisposablesAreLeakedInTestSuite();
|
||||
|
||||
test('Calls item provider', async function () {
|
||||
await withTestNotebook(
|
||||
[
|
||||
|
|
|
@ -9,9 +9,12 @@
|
|||
*--------------------------------------------------------------------------------------------*/
|
||||
|
||||
import * as assert from 'assert';
|
||||
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
|
||||
import { formatCellDuration } from 'vs/workbench/contrib/notebook/browser/contrib/cellStatusBar/executionStatusBarItemController';
|
||||
|
||||
suite('notebookBrowser', () => {
|
||||
ensureNoDisposablesAreLeakedInTestSuite();
|
||||
|
||||
test('formatCellDuration', function () {
|
||||
assert.strictEqual(formatCellDuration(0, false), '0.0s');
|
||||
assert.strictEqual(formatCellDuration(0), '0ms');
|
||||
|
|
|
@ -11,8 +11,10 @@ import * as assert from 'assert';
|
|||
import { VSBuffer } from 'vs/base/common/buffer';
|
||||
import { IOutputItemDto } from 'vs/workbench/contrib/notebook/common/notebookCommon';
|
||||
import { copyCellOutput } from 'vs/workbench/contrib/notebook/browser/contrib/clipboard/cellOutputClipboard';
|
||||
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
|
||||
|
||||
suite('Cell Output Clipboard Tests', () => {
|
||||
ensureNoDisposablesAreLeakedInTestSuite();
|
||||
|
||||
class ClipboardService {
|
||||
private _clipboardContent = '';
|
||||
|
|
|
@ -36,6 +36,10 @@ suite('NotebookExecutionService', () => {
|
|||
let kernelService: INotebookKernelService;
|
||||
let disposables: DisposableStore;
|
||||
|
||||
teardown(() => {
|
||||
disposables.dispose();
|
||||
});
|
||||
|
||||
setup(function () {
|
||||
|
||||
disposables = new DisposableStore();
|
||||
|
@ -71,15 +75,11 @@ suite('NotebookExecutionService', () => {
|
|||
}
|
||||
});
|
||||
|
||||
kernelService = instantiationService.createInstance(NotebookKernelService);
|
||||
kernelService = disposables.add(instantiationService.createInstance(NotebookKernelService));
|
||||
instantiationService.set(INotebookKernelService, kernelService);
|
||||
contextKeyService = instantiationService.get(IContextKeyService);
|
||||
});
|
||||
|
||||
teardown(() => {
|
||||
disposables.dispose();
|
||||
});
|
||||
|
||||
async function withTestNotebook(cells: [string, string, CellKind, IOutputDto[], NotebookCellMetadata][], callback: (viewModel: NotebookViewModel, textModel: NotebookTextModel) => void | Promise<void>) {
|
||||
return _withTestNotebook(cells, (editor, viewModel) => callback(viewModel, viewModel.notebookDocument));
|
||||
}
|
||||
|
|
|
@ -34,6 +34,10 @@ suite('NotebookExecutionStateService', () => {
|
|||
let disposables: DisposableStore;
|
||||
let testNotebookModel: NotebookTextModel | undefined;
|
||||
|
||||
teardown(() => {
|
||||
disposables.dispose();
|
||||
});
|
||||
|
||||
setup(function () {
|
||||
|
||||
disposables = new DisposableStore();
|
||||
|
@ -59,14 +63,10 @@ suite('NotebookExecutionStateService', () => {
|
|||
}
|
||||
});
|
||||
|
||||
kernelService = instantiationService.createInstance(NotebookKernelService);
|
||||
kernelService = disposables.add(instantiationService.createInstance(NotebookKernelService));
|
||||
instantiationService.set(INotebookKernelService, kernelService);
|
||||
instantiationService.set(INotebookExecutionService, instantiationService.createInstance(NotebookExecutionService));
|
||||
instantiationService.set(INotebookExecutionStateService, instantiationService.createInstance(NotebookExecutionStateService));
|
||||
});
|
||||
|
||||
teardown(() => {
|
||||
disposables.dispose();
|
||||
instantiationService.set(INotebookExecutionService, disposables.add(instantiationService.createInstance(NotebookExecutionService)));
|
||||
instantiationService.set(INotebookExecutionStateService, disposables.add(instantiationService.createInstance(NotebookExecutionStateService)));
|
||||
});
|
||||
|
||||
async function withTestNotebook(cells: [string, string, CellKind, IOutputDto[], NotebookCellMetadata][], callback: (viewModel: NotebookViewModel, textModel: NotebookTextModel) => void | Promise<void>) {
|
||||
|
|
Loading…
Reference in a new issue