From 81fd2d3f5547ebe5fca06b9485bd3d0100bdff04 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Fri, 13 Jul 2018 17:13:54 +0200 Subject: [PATCH] tweak shadow and some spacings --- .../browser/parts/editor/breadcrumbsPicker.ts | 2 +- .../parts/editor/media/breadcrumbscontrol.css | 15 ------------ .../parts/editor/media/notabstitlecontrol.css | 23 ++++++++++--------- .../parts/editor/media/tabstitlecontrol.css | 5 ++-- 4 files changed, 16 insertions(+), 29 deletions(-) diff --git a/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts b/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts index 41e88abf613..81488911964 100644 --- a/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts +++ b/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts @@ -48,7 +48,7 @@ export abstract class BreadcrumbsPicker { this._domNode.className = 'monaco-breadcrumbs-picker show-file-icons'; const color = this._themeService.getTheme().getColor(breadcrumbsActiveSelectionBackground); this._domNode.style.background = color.toString(); - this._domNode.style.boxShadow = `2px 2px 3px ${color.darken(.1)}`; + this._domNode.style.boxShadow = `0px 5px 8px ${color.darken(.2)}`; this._domNode.style.position = 'absolute'; this._domNode.style.zIndex = '1000'; container.appendChild(this._domNode); diff --git a/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css b/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css index 28e022b7f15..7bb6361b0c5 100644 --- a/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css +++ b/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css @@ -11,21 +11,6 @@ opacity: .8; } -.monaco-workbench>.part.editor>.content .editor-group-container .breadcrumbs-control .monaco-breadcrumb-item .symbol-icon{ - margin-left: 4px; - padding-right: 2px; -} - -.monaco-workbench>.part.editor>.content .editor-group-container .breadcrumbs-control .monaco-breadcrumbs .monaco-breadcrumb-item:nth-child(2) { - /*first-child is the style-element*/ - margin-left: 8px; -} - -.monaco-workbench>.part.editor>.content .editor-group-container .breadcrumbs-control .monaco-breadcrumbs .monaco-breadcrumb-item:last-child { - /*first-child is the style-element*/ - margin-right: 8px; -} - /* todo@joh move somewhere else */ .monaco-workbench .monaco-breadcrumbs-picker .highlighting-tree { diff --git a/src/vs/workbench/browser/parts/editor/media/notabstitlecontrol.css b/src/vs/workbench/browser/parts/editor/media/notabstitlecontrol.css index 4c89d58494f..c719adaadd8 100644 --- a/src/vs/workbench/browser/parts/editor/media/notabstitlecontrol.css +++ b/src/vs/workbench/browser/parts/editor/media/notabstitlecontrol.css @@ -31,21 +31,13 @@ } .monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control { - padding-left: 8px; + padding: 0 6px; } .monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item { font-size: 0.9em; } -.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item:nth-child(2) { - margin-left: 0px; -} - -.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item:last-child { - padding-right: 2px; -} - .monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control.preview .monaco-breadcrumb-item { font-style: italic; } @@ -61,12 +53,21 @@ .monaco-workbench.windows > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item:not(:first-child)::before { content: '\\'; } +.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item.shows-symbol-icon, +.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item:last-child { + padding-right: 4px; /* does not have trailing separator*/ +} -.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item.shows-symbol-icon:not(:first-child)::before { - /* breadcrumbs items that show a symbol icon don't show slashes */ +.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item.shows-symbol-icon::before { + padding-right: 2px; content: ' '; } +.monaco-workbench > .part.editor > .content .editor-group-container > .title .no-tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item.shows-symbol-icon .symbol-icon { + width: 15px; + min-width: 15px; +} + /* Title Actions */ .monaco-workbench > .part.editor > .content .editor-group-container > .title .title-actions { display: flex; diff --git a/src/vs/workbench/browser/parts/editor/media/tabstitlecontrol.css b/src/vs/workbench/browser/parts/editor/media/tabstitlecontrol.css index 065b844c4b2..6217b034240 100644 --- a/src/vs/workbench/browser/parts/editor/media/tabstitlecontrol.css +++ b/src/vs/workbench/browser/parts/editor/media/tabstitlecontrol.css @@ -267,6 +267,7 @@ height: 18px; /* tweak the icon size of the editor labels when icons are enabled */ } -.monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item:last-child { - padding-right: 8px; +.monaco-workbench > .part.editor > .content .editor-group-container > .title .tabs-breadcrumbs .breadcrumbs-control .monaco-breadcrumb-item { + padding-right: 4px; } +