From 7b80b25ddf361f6bc94eb32b76f91062b2336d15 Mon Sep 17 00:00:00 2001
From: Benjamin Pasero <benjpas@microsoft.com>
Date: Thu, 13 Jun 2019 08:03:41 +0200
Subject: [PATCH] bump electron@3.2.4

---
 .yarnrc                   |  2 +-
 cgmanifest.json           |  2 +-
 src/typings/electron.d.ts | 62 +++++++++++++++++----------------------
 test/smoke/package.json   |  2 +-
 test/smoke/yarn.lock      |  8 ++---
 5 files changed, 34 insertions(+), 42 deletions(-)

diff --git a/.yarnrc b/.yarnrc
index 7e63643de04..e3807c54e51 100644
--- a/.yarnrc
+++ b/.yarnrc
@@ -1,3 +1,3 @@
 disturl "https://atom.io/download/electron"
-target "4.2.3"
+target "4.2.4"
 runtime "electron"
diff --git a/cgmanifest.json b/cgmanifest.json
index 6cebbffd6b9..42a65648e59 100644
--- a/cgmanifest.json
+++ b/cgmanifest.json
@@ -65,7 +65,7 @@
 			},
 			"isOnlyProductionDependency": true,
 			"license": "MIT",
-			"version": "4.2.3"
+			"version": "4.2.4"
 		},
 		{
 			"component": {
diff --git a/src/typings/electron.d.ts b/src/typings/electron.d.ts
index 59163a017cc..df64e7a0b28 100644
--- a/src/typings/electron.d.ts
+++ b/src/typings/electron.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for Electron 4.2.3
+// Type definitions for Electron 4.2.4
 // Project: http://electronjs.org/
 // Definitions by: The Electron Team <https://github.com/electron/electron>
 // Definitions: https://github.com/electron/electron-typescript-definitions
@@ -1338,16 +1338,21 @@ declare namespace Electron {
 		removeListener(event: 'new-window-for-tab', listener: Function): this;
 		/**
 		 * Emitted when the document changed its title, calling event.preventDefault() will
-		 * prevent the native window's title from changing.
+		 * prevent the native window's title from changing. explicitSet is false when title
+		 * is synthesized from file url.
 		 */
 		on(event: 'page-title-updated', listener: (event: Event,
-			title: string, explicitSet: boolean) => void): this;
+			title: string,
+			explicitSet: boolean) => void): this;
 		once(event: 'page-title-updated', listener: (event: Event,
-			title: string, explicitSet: boolean) => void): this;
+			title: string,
+			explicitSet: boolean) => void): this;
 		addListener(event: 'page-title-updated', listener: (event: Event,
-			title: string, explicitSet: boolean) => void): this;
+			title: string,
+			explicitSet: boolean) => void): this;
 		removeListener(event: 'page-title-updated', listener: (event: Event,
-			title: string, explicitSet: boolean) => void): this;
+			title: string,
+			explicitSet: boolean) => void): this;
 		/**
 		 * Emitted when the web page has been rendered (while not being shown) and window
 		 * can be displayed without a visual flash.
@@ -3355,35 +3360,6 @@ declare namespace Electron {
 		type?: ('task' | 'separator' | 'file');
 	}
 
-	interface MemoryInfo {
-
-		// Docs: http://electronjs.org/docs/api/structures/memory-info
-
-		/**
-		 * The maximum amount of memory that has ever been pinned to actual physical RAM.
-		 * On macOS its value will always be 0.
-		 */
-		peakWorkingSetSize: number;
-		/**
-		 * Process id of the process.
-		 */
-		pid: number;
-		/**
-		 * The amount of memory not shared by other processes, such as JS heap or HTML
-		 * content.
-		 */
-		privateBytes: number;
-		/**
-		 * The amount of memory shared between processes, typically memory consumed by the
-		 * Electron code itself
-		 */
-		sharedBytes: number;
-		/**
-		 * The amount of memory currently pinned to actual physical RAM.
-		 */
-		workingSetSize: number;
-	}
-
 	interface MemoryUsageDetails {
 
 		// Docs: http://electronjs.org/docs/api/structures/memory-usage-details
@@ -5919,6 +5895,22 @@ declare namespace Electron {
 			 * Array of URLs.
 			 */
 			favicons: string[]) => void): this;
+		/**
+		 * Fired when page title is set during navigation. explicitSet is false when title
+		 * is synthesized from file url.
+		 */
+		on(event: 'page-title-updated', listener: (event: Event,
+			title: string,
+			explicitSet: boolean) => void): this;
+		once(event: 'page-title-updated', listener: (event: Event,
+			title: string,
+			explicitSet: boolean) => void): this;
+		addListener(event: 'page-title-updated', listener: (event: Event,
+			title: string,
+			explicitSet: boolean) => void): this;
+		removeListener(event: 'page-title-updated', listener: (event: Event,
+			title: string,
+			explicitSet: boolean) => void): this;
 		/**
 		 * Emitted when a new frame is generated. Only the dirty area is passed in the
 		 * buffer.
diff --git a/test/smoke/package.json b/test/smoke/package.json
index e19de8f9de2..2aff1bced09 100644
--- a/test/smoke/package.json
+++ b/test/smoke/package.json
@@ -22,7 +22,7 @@
     "@types/webdriverio": "4.6.1",
     "concurrently": "^3.5.1",
     "cpx": "^1.5.0",
-    "electron": "4.2.3",
+    "electron": "4.2.4",
     "htmlparser2": "^3.9.2",
     "mkdirp": "^0.5.1",
     "mocha": "^5.2.0",
diff --git a/test/smoke/yarn.lock b/test/smoke/yarn.lock
index cdcb6f7dada..da2b5b77ed5 100644
--- a/test/smoke/yarn.lock
+++ b/test/smoke/yarn.lock
@@ -596,10 +596,10 @@ electron-download@^4.1.0:
     semver "^5.4.1"
     sumchecker "^2.0.2"
 
-electron@4.2.3:
-  version "4.2.3"
-  resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.3.tgz#5d45da9dd5ae97269dbee2623840da808c72d29d"
-  integrity sha512-nx+jHxj2eNhaYHXFGdzr7zgSphpVHEU9WAu6qqEUsQ936X3c6bQ5Bdg08KbHZj+cyRRQ06JMu6/ILh5pWrDZaA==
+electron@4.2.4:
+  version "4.2.4"
+  resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.4.tgz#68ca7bd4ff2c16b9205549322f0f1cda4ebc9ff9"
+  integrity sha512-d4wEwJluMsRyRgbukLmFVTb6l1J+mc3RLB1ctbpMlSWDFvs+zknPWa+cHBzTWwrdgwINLddr69qsAW1ku6FqYw==
   dependencies:
     "@types/node" "^10.12.18"
     electron-download "^4.1.0"