development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

debug: fix call stack dropdown menu hidden (#209042)

Browse source 
Fixes #208817
This commit is contained in:
Connor Peet 2024-03-28 10:49:06 -07:00 committed by GitHub
parent 80ca971617
commit 7b2cc73cf2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/vs/platform/actions/browser/dropdownWithPrimaryActionViewItem.ts
View file

@ -25,6 +25,7 @@ export interface IDropdownWithPrimaryActionViewItemOptions {
actionRunner?: IActionRunner;
getKeyBinding?: (action: IAction) => ResolvedKeybinding | undefined;
hoverDelegate?: IHoverDelegate;
menuAsChild?: boolean;
}
export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
@ -57,7 +58,7 @@ export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
}
this._dropdown = new DropdownMenuActionViewItem(dropdownAction, dropdownMenuActions, this._contextMenuProvider, {
menuAsChild: true,
menuAsChild: _options?.menuAsChild ?? true,
classNames: className ? ['codicon', 'codicon-chevron-down', className] : ['codicon', 'codicon-chevron-down'],
actionRunner: this._options?.actionRunner,
keybindingProvider: this._options?.getKeyBinding,

2
src/vs/workbench/contrib/debug/browser/callStackView.ts
View file

@ -550,7 +550,7 @@ class SessionsRenderer implements ICompressibleTreeRenderer<IDebugSession, Fuzzy
actionViewItemProvider: (action, options) => {
if ((action.id === STOP_ID || action.id === DISCONNECT_ID) && action instanceof MenuItemAction) {
stopActionViewItemDisposables.clear();
const item = this.instantiationService.invokeFunction(accessor => createDisconnectMenuItemAction(action as MenuItemAction, stopActionViewItemDisposables, accessor, options));
const item = this.instantiationService.invokeFunction(accessor => createDisconnectMenuItemAction(action as MenuItemAction, stopActionViewItemDisposables, accessor, { ...options, menuAsChild: false }));
if (item) {
return item;
}