development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #138657 from microsoft/sandy081/fix129861

Browse source 
Save through text model service if model is dirty
This commit is contained in:
Sandeep Somavarapu 2021-12-08 17:43:25 +01:00 committed by GitHub
parent bcc088aa50 8e64d75b24
commit 7a1a06a0fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/vs/workbench/services/configuration/common/configurationEditingService.ts
View file

@ -181,7 +181,8 @@ export class ConfigurationEditingService {
const reference = await this.resolveModelReference(resource);
try {
const formattingOptions = this.getFormattingOptions(reference.object.textEditorModel);
if (this.uriIdentityService.extUri.isEqual(resource, this.environmentService.settingsResource)) {
if (!this.textFileService.isDirty(resource) /* go through text model save if the model is dirty */
&& this.uriIdentityService.extUri.isEqual(resource, this.environmentService.settingsResource)) {
await this.userConfigurationFileService.updateSettings({ path: operation.jsonPath, value: operation.value }, formattingOptions);
} else {
await this.updateConfiguration(operation, reference.object.textEditorModel, formattingOptions);