This commit is contained in:
Pine Wu 2019-07-12 14:20:49 -07:00
parent e5eabc5883
commit 7a127f44ab
2 changed files with 6 additions and 4 deletions

View file

@ -969,7 +969,7 @@ export class SettingsEditor2 extends BaseEditor {
if (key) {
const focusedKey = focusedSetting.getAttribute(AbstractSettingRenderer.SETTING_KEY_ATTR);
if (focusedKey === key &&
!DOM.hasClass(focusedSetting, 'setting-item-list')) { // update `exclude`s live, as they have a separate "submit edit" step built in before this
!DOM.hasClass(focusedSetting, 'setting-item-list')) { // update `list`s live, as they have a separate "submit edit" step built in before this
this.updateModifiedLabelForKey(key);
this.scheduleRefresh(focusedSetting, key);

View file

@ -246,7 +246,8 @@ export class ListSettingWidget extends Disposable {
editActionTooltip: localize('editItem', "Edit Item"),
complexEditActionTooltip: localize('editItemInSettingsJson', "Edit Item in settings.json"),
addButtonLabel: localize('addItem', "Add Item"),
inputPlaceholder: localize('itemInputPlaceholder', "String Item...")
inputPlaceholder: localize('itemInputPlaceholder', "String Item..."),
siblingInputPlaceholder: localize('listSiblingInputPlaceholder', "Sibling...")
};
}
@ -459,7 +460,7 @@ export class ListSettingWidget extends Disposable {
let siblingInput: InputBox;
if (item.sibling) {
siblingInput = new InputBox(rowElement, this.contextViewService, {
placeholder: localize('excludeSiblingInputPlaceholder', "When Pattern Is Present...")
placeholder: this.getLocalizedStrings().siblingInputPlaceholder
});
siblingInput.element.classList.add('setting-list-siblingInput');
this.listDisposables.add(siblingInput);
@ -501,7 +502,8 @@ export class ExcludeSettingWidget extends ListSettingWidget {
editActionTooltip: localize('editExcludeItem', "Edit Exclude Item"),
complexEditActionTooltip: localize('editExcludeItemInSettingsJson', "Edit Exclude Item in settings.json"),
addButtonLabel: localize('addPattern', "Add Pattern"),
inputPlaceholder: localize('excludePatternInputPlaceholder', "Exclude Pattern...")
inputPlaceholder: localize('excludePatternInputPlaceholder', "Exclude Pattern..."),
siblingInputPlaceholder: localize('excludeSiblingInputPlaceholder', "When Pattern Is Present...")
};
}