development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-11-05 18:29:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert bad fix for unit test as part of TS 3.1

Browse source 
Adding todo about addressing this
This commit is contained in:
Matt Bierner 2018-10-01 11:13:24 -07:00
parent d37076a596
commit 78d8277315
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/services/decorations/test/browser/decorationsService.test.ts
View file

@ -216,6 +216,7 @@ suite('DecorationsService', function () {
test('Decorations not bubbling... #48745', function () {
let resolve: Function;
let reg = service.registerDecorationsProvider({
label: 'Test',
onDidChange: Event.None,
@ -223,10 +224,13 @@ suite('DecorationsService', function () {
if (uri.path.match(/hello$/)) {
return { tooltip: 'FOO', weight: 17, bubble: true };
} else {
throw new Error('unexpected uri');
return new Promise<IDecorationData>(_resolve => resolve = _resolve);
}
}
});
// TODO: TS 3.1 upgrade. Why do we need 'resolve' if it is never actually resolved?
// tslint:disable-next-line:no-unused-expression
resolve as any;
let data1 = service.getDecoration(URI.parse('a:b/'), true);
assert.ok(!data1);