development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

debug: make serverReadyAction play nicely with js-debug

Browse source 
Fixes https://github.com/microsoft/vscode/issues/86035
Fixes https://github.com/microsoft/vscode-js-debug/issues/440
This commit is contained in:
Connor Peet 2020-09-08 11:52:54 -07:00
parent 62f1bf8c6b
commit 76e45c2b69
No known key found for this signature in database
GPG key ID: CF8FD2EA0DBC61BD
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
extensions/debug-server-ready/src/extension.ts
View file

@ -146,18 +146,13 @@ class ServerReadyDetector extends vscode.Disposable {
break;
case 'debugWithChrome':
if (vscode.env.remoteName === 'wsl' || !!vscode.extensions.getExtension('msjsdiag.debugger-for-chrome')) {
vscode.debug.startDebugging(session.workspaceFolder, {
type: 'chrome',
name: 'Chrome Debug',
request: 'launch',
url: uri,
webRoot: args.webRoot || WEB_ROOT
}, session);
} else {
const errMsg = localize('server.ready.chrome.not.installed', "The action '{0}' requires the '{1}' extension.", 'debugWithChrome', 'Debugger for Chrome');
vscode.window.showErrorMessage(errMsg, { modal: true }).then(_ => undefined);
}
vscode.debug.startDebugging(session.workspaceFolder, {
type: 'pwa-chrome',
name: 'Chrome Debug',
request: 'launch',
url: uri,
webRoot: args.webRoot || WEB_ROOT
});
break;
default: