development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-07-17 11:07:22 +00:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

trusted types - use textContent for style elements, fyi @rebornix

Browse source
This commit is contained in:
Johannes Rieken 2020-09-09 14:37:27 +02:00
parent 900e16aea7
commit 758f35532b
3 changed files with 5 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
.vscode/searches/TrustedTypes.code-search vendored
View file

@ -4,7 +4,7 @@
# Excluding: *.test.ts
# ContextLines: 3
44 results - 27 files
42 results - 25 files
src/vs/base/browser/markdownRenderer.ts:
156 const strValue = values[0];
@ -267,24 +267,6 @@ src/vs/workbench/contrib/debug/browser/repl.ts:
311 font-size: ${fontSize}px;
312 font-family: ${fontFamily};
src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.ts:
222
223 const newStyles = content.join('\n');
224 if (newStyles !== this.styleElement.innerHTML) {
225: this.styleElement.innerHTML = newStyles;
226 }
227 }
228 }
src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts:
1033
1034 const newStyles = content.join('\n');
1035 if (newStyles !== this.styleElement.innerHTML) {
1036: this.styleElement.innerHTML = newStyles;
1037 }
1038 }
1039
src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts:
454
455 private getMarkdownDragImage(templateData: MarkdownCellRenderTemplate): HTMLElement {
@ -335,7 +317,6 @@ src/vs/workbench/contrib/webview/browser/webviewIconManager.ts:
64: this._styleElement.innerHTML = cssRules.join('\n');
65 }
66 }
67
src/vs/workbench/contrib/webview/browser/pre/main.js:
386 // apply default styles

4
src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.ts
View file

@ -221,8 +221,8 @@ export class NotebookTextDiffList extends WorkbenchList<CellDiffViewModel> imple
}
const newStyles = content.join('\n');
if (newStyles !== this.styleElement.innerHTML) {
this.styleElement.innerHTML = newStyles;
if (newStyles !== this.styleElement.textContent) {
this.styleElement.textContent = newStyles;
}
}
}

4
src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts
View file

@ -1032,8 +1032,8 @@ export class NotebookCellList extends WorkbenchList<CellViewModel> implements ID
}
const newStyles = content.join('\n');
if (newStyles !== this.styleElement.innerHTML) {
this.styleElement.innerHTML = newStyles;
if (newStyles !== this.styleElement.textContent) {
this.styleElement.textContent = newStyles;
}
}