development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

validate extension-given file system provider (#175357)

Browse source 
fixes https://github.com/microsoft/vscode/issues/173502
This commit is contained in:
Johannes Rieken 2023-02-24 17:54:04 +01:00 committed by GitHub
parent 02fa5bc980
commit 756ef3ff47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/vs/workbench/api/common/extHostFileSystem.ts
View file

@ -128,9 +128,11 @@ export class ExtHostFileSystem implements ExtHostFileSystemShape {
this._linkProviderRegistration?.dispose();
}
registerFileSystemProvider(extension: IExtensionDescription, scheme: string, provider: vscode.FileSystemProvider, options: { isCaseSensitive?: boolean; isReadonly?: boolean } = {}) {
// validate the given provider is complete
ExtHostFileSystem._validateFileSystemProvider(provider);
if (this._registeredSchemes.has(scheme)) {
throw new Error(`a provider for the scheme '${scheme}' is already registered`);
}
@ -203,6 +205,36 @@ export class ExtHostFileSystem implements ExtHostFileSystemShape {
});
}
private static _validateFileSystemProvider(provider: vscode.FileSystemProvider) {
if (!provider) {
throw new Error('MISSING provider');
}
if (typeof provider.watch !== 'function') {
throw new Error('Provider does NOT implement watch');
}
if (typeof provider.stat !== 'function') {
throw new Error('Provider does NOT implement stat');
}
if (typeof provider.readDirectory !== 'function') {
throw new Error('Provider does NOT implement readDirectory');
}
if (typeof provider.createDirectory !== 'function') {
throw new Error('Provider does NOT implement createDirectory');
}
if (typeof provider.readFile !== 'function') {
throw new Error('Provider does NOT implement readFile');
}
if (typeof provider.writeFile !== 'function') {
throw new Error('Provider does NOT implement writeFile');
}
if (typeof provider.delete !== 'function') {
throw new Error('Provider does NOT implement delete');
}
if (typeof provider.rename !== 'function') {
throw new Error('Provider does NOT implement rename');
}
}
private static _asIStat(stat: vscode.FileStat): files.IStat {
const { type, ctime, mtime, size, permissions } = stat;
return { type, ctime, mtime, size, permissions };