development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

TestResolver, use 127.0.0.1, not localhost

Browse source
This commit is contained in:
Martin Aeschlimann 2021-05-25 16:30:57 +02:00
parent a78bc1aa96
commit 741beb8f26
No known key found for this signature in database
GPG key ID: 2609A01E695523E3
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
extensions/vscode-test-resolver/src/extension.ts
View file

@ -52,7 +52,7 @@ export function activate(context: vscode.ExtensionContext) {
const match = lastProgressLine.match(/Extension host agent listening on (\d+)/);
if (match) {
isResolved = true;
res(new vscode.ResolvedAuthority('localhost', parseInt(match[1], 10))); // success!
res(new vscode.ResolvedAuthority('127.0.0.1', parseInt(match[1], 10))); // success!
}
lastProgressLine = '';
} else if (chr === CharCode.Backspace) {
@ -200,7 +200,7 @@ export function activate(context: vscode.ExtensionContext) {
}
});
});
proxyServer.listen(0, () => {
proxyServer.listen(0, '127.0.0.1', () => {
const port = (<net.AddressInfo>proxyServer.address()).port;
outputChannel.appendLine(`Going through proxy at port ${port}`);
const r: vscode.ResolverResult = new vscode.ResolvedAuthority('127.0.0.1', port);
@ -268,7 +268,7 @@ export function activate(context: vscode.ExtensionContext) {
const port = Number.parseInt(result);
vscode.workspace.openTunnel({
remoteAddress: {
host: 'localhost',
host: '127.0.0.1',
port: port
},
localAddressPort: port + 1
@ -406,10 +406,10 @@ async function tunnelFactory(tunnelOptions: vscode.TunnelOptions, tunnelCreation
if (localPort < 1024 && process.platform !== 'win32') {
localPort = 0;
}
proxyServer.listen(localPort, () => {
proxyServer.listen(localPort, '127.0.0.1', () => {
const localPort = (<net.AddressInfo>proxyServer.address()).port;
outputChannel.appendLine(`New test resolver tunnel service: Remote ${tunnelOptions.remoteAddress.port} -> local ${localPort}`);
const tunnel = newTunnel({ host: 'localhost', port: localPort });
const tunnel = newTunnel({ host: '127.0.0.1', port: localPort });
tunnel.onDidDispose(() => proxyServer.close());
res(tunnel);
});
@ -423,8 +423,8 @@ function runHTTPTestServer(port: number): vscode.Disposable {
res.end(`Hello, World from test server running on port ${port}!`);
});
remoteServers.push(port);
server.listen(port);
const message = `Opened HTTP server on http://localhost:${port}`;
server.listen(port, '127.0.0.1');
const message = `Opened HTTP server on http://127.0.0.1:${port}`;
console.log(message);
outputChannel.appendLine(message);
return {