development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Join with empty string to mirror what l10n-dev does (#171125)

Browse source 
This should have been the case all along, but I missed it and probably thought not passing anything joins with empty string.

fixes https://github.com/microsoft/vscode-l10n/issues/77
This commit is contained in:
Tyler James Leonhardt 2023-01-11 17:25:51 -08:00 committed by GitHub
parent 87d1de6a45
commit 6d40104789
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/api/common/extHostLocalizationService.ts
View file

@ -40,7 +40,7 @@ export class ExtHostLocalizationService implements ExtHostLocalizationShape {
let key = message;
if (comment && comment.length > 0) {
key += `/${Array.isArray(comment) ? comment.join() : comment}`;
key += `/${Array.isArray(comment) ? comment.join('') : comment}`;
}
const str = this.bundleCache.get(extensionId)?.contents[key];
if (!str) {