development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove liveshare specific registerContentProvider api (#164497)

Browse source 
Liveshare has migrated off of the content provider api
This commit is contained in:
Matt Bierner 2022-10-24 13:39:28 -07:00 committed by GitHub
parent ed31e676b6
commit 6c3f161641
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/api/common/extHost.api.impl.ts
View file

@ -954,7 +954,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
extHostApiDeprecation.report('workspace.registerNotebookContentProvider', extension,
`The notebookContentProvider API is not on track for finalization and will be removed.`);
return extHostNotebook.registerNotebookContentProvider(extension, viewType, provider, options, isProposedApiEnabled(extension, 'notebookLiveShare') ? registration : undefined);
return extHostNotebook.registerNotebookContentProvider(extension, viewType, provider, options);
},
onDidChangeConfiguration: (listener: (_: any) => any, thisArgs?: any, disposables?: extHostTypes.Disposable[]) => {
return configProvider.onDidChangeConfiguration(listener, thisArgs, disposables);

5
src/vs/workbench/api/common/extHostNotebook.ts
View file

@ -149,8 +149,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
extension: IExtensionDescription,
viewType: string,
provider: vscode.NotebookContentProvider,
options?: vscode.NotebookDocumentContentOptions,
registration?: vscode.NotebookRegistrationData
options?: vscode.NotebookDocumentContentOptions
): vscode.Disposable {
if (isFalsyOrWhitespace(viewType)) {
throw new Error(`viewType cannot be empty or just whitespace`);
@ -165,7 +164,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
{ id: extension.identifier, location: extension.extensionLocation },
viewType,
typeConverters.NotebookDocumentContentOptions.from(options),
ExtHostNotebookController._convertNotebookRegistrationData(extension, registration)
undefined,
);
return new extHostTypes.Disposable(() => {

5
src/vscode-dts/vscode.proposed.notebookLiveShare.d.ts vendored
View file

@ -14,11 +14,6 @@ declare module 'vscode' {
}
export namespace workspace {
/**
* SPECIAL overload with NotebookRegistrationData
* @deprecated
*/
export function registerNotebookContentProvider(notebookType: string, provider: NotebookContentProvider, options?: NotebookDocumentContentOptions, registrationData?: NotebookRegistrationData): Disposable;
// SPECIAL overload with NotebookRegistrationData
export function registerNotebookSerializer(notebookType: string, serializer: NotebookSerializer, options?: NotebookDocumentContentOptions, registration?: NotebookRegistrationData): Disposable;