development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-24 19:46:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pick up latest notebook renderer API typings (#161135)

Browse source
This commit is contained in:
Matt Bierner 2022-09-16 13:09:20 -07:00 committed by GitHub
parent 687712b871
commit 6c3e1f0ff1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -116,7 +116,7 @@
"@types/sinon": "^10.0.2",
"@types/sinon-test": "^2.4.2",
"@types/trusted-types": "^1.0.6",
"@types/vscode-notebook-renderer": "^1.60.0",
"@types/vscode-notebook-renderer": "^1.72.0",
"@types/webpack": "^4.41.25",
"@types/wicg-file-system-access": "^2020.9.5",
"@types/windows-foreground-love": "^0.3.0",

8
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file

@ -1373,10 +1373,6 @@ async function webviewPreloads(ctx: PreloadContext) {
}
};
type ExtendedRendererApi = rendererApi.RendererApi & {
renderOutputItem(outputItem: rendererApi.OutputItem, element: HTMLElement, signal: AbortSignal): void | Promise<void>;
};
const renderers = new class {
private readonly _renderers = new Map</* id */ string, Renderer>();
@ -1490,7 +1486,7 @@ async function webviewPreloads(ctx: PreloadContext) {
const renderer = await renderers[0].load();
if (renderer) {
await (renderer as ExtendedRendererApi).renderOutputItem(info, element, signal);
await renderer.renderOutputItem(info, element, signal);
}
}
}();
@ -2139,7 +2135,7 @@ async function webviewPreloads(ctx: PreloadContext) {
const errors = preloadsAndErrors.filter((e): e is Error => e instanceof Error);
showPreloadErrors(this.element, ...errors);
} else {
const rendererApi = preloadsAndErrors[0] as ExtendedRendererApi;
const rendererApi = preloadsAndErrors[0] as rendererApi.RendererApi;
try {
const item = createOutputItem(this.outputId, content.mimeType, content.metadata, content.valueBytes);

8
yarn.lock
View file

@ -1091,10 +1091,10 @@
"@types/expect" "^1.20.4"
"@types/node" "*"
"@types/vscode-notebook-renderer@^1.60.0":
version "1.60.0"
resolved "https://registry.yarnpkg.com/@types/vscode-notebook-renderer/-/vscode-notebook-renderer-1.60.0.tgz#8a67d561f48ddf46a95dfa9f712a79c72c7b8f7a"
integrity sha512-u7TD2uuEZTVuitx0iijOJdKI0JLiQP6PsSBSRy2XmHXUOXcp5p1S56NrjOEDoF+PIHd3NL3eO6KTRSf5nukDqQ==
"@types/vscode-notebook-renderer@^1.72.0":
version "1.72.0"
resolved "https://registry.yarnpkg.com/@types/vscode-notebook-renderer/-/vscode-notebook-renderer-1.72.0.tgz#8943dc3cef0ced2dfb1e04c0a933bd289e7d5199"
integrity sha512-5iTjb39DpLn03ULUwrDR3L2Dy59RV4blSUHy0oLdQuIY11PhgWO4mXIcoFS0VxY1GZQ4IcjSf3ooT2Jrrcahnw==
"@types/webpack-sources@*":
version "2.1.0"