From 68a115bdd122026d1c9a2e57fdf4a02ef333ef3f Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Tue, 27 Jul 2021 22:11:50 +0200 Subject: [PATCH] Fix #129549 --- .../extensions/browser/extensionsWidgets.ts | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts b/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts index ec870428ced..17c5138f1cd 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts @@ -417,11 +417,21 @@ export class ExtensionHoverWidget extends ExtensionWidget { markdown.appendMarkdown(`**${this.extension.displayName}** _v${this.extension.version}_`); markdown.appendText(`\n`); + if (this.extension.description) { + markdown.appendMarkdown(`${this.extension.description}`); + markdown.appendText(`\n`); + } + const extensionRuntimeStatus = this.extensionsWorkbenchService.getExtensionStatus(this.extension); const extensionStatus = this.extensionStatusAction.status; const reloadRequiredMessage = this.reloadAction.enabled ? this.reloadAction.tooltip : ''; + const recommendationMessage = this.getRecommendationMessage(this.extension); + + if (extensionRuntimeStatus || extensionStatus || reloadRequiredMessage || recommendationMessage) { + + markdown.appendMarkdown(`---`); + markdown.appendText(`\n`); - if (extensionRuntimeStatus || extensionStatus || reloadRequiredMessage) { if (extensionRuntimeStatus) { if (extensionRuntimeStatus.activationTimes) { const activationTime = extensionRuntimeStatus.activationTimes.codeLoadingTime + extensionRuntimeStatus.activationTimes.activateCallTime; @@ -460,19 +470,10 @@ export class ExtensionHoverWidget extends ExtensionWidget { markdown.appendText(`\n`); } - markdown.appendMarkdown(`---`); - markdown.appendText(`\n`); - } - - if (this.extension.description) { - markdown.appendMarkdown(`${this.extension.description}`); - markdown.appendText(`\n`); - } - - const recommendationMessage = this.getRecommendationMessage(this.extension); - if (recommendationMessage) { - markdown.appendMarkdown(recommendationMessage); - markdown.appendText(`\n`); + if (recommendationMessage) { + markdown.appendMarkdown(recommendationMessage); + markdown.appendText(`\n`); + } } return markdown;