development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-30 04:17:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve how layout is disabled/share code

Browse source
This commit is contained in:
Daniel Imms 2018-02-28 12:01:06 -08:00
parent b6ba17d890
commit 683602d880
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/vs/workbench/parts/terminal/electron-browser/terminalTab.ts
View file

@ -127,10 +127,7 @@ class SplitPaneContainer {
this._children.push(child);
}
// Add the view, disabling layout/resize events in the terminal to prevent multiple resizes
this._children.forEach(c => c.instance.disableLayout = true);
this._splitView.addView(child, size, index);
this._children.forEach(c => c.instance.disableLayout = false);
this._withDisabledLayout(() => this._splitView.addView(child, size, index));
this.resetSize();
this._refreshOrderClasses();
@ -196,11 +193,19 @@ class SplitPaneContainer {
// Create new split view with updated orientation
this._createSplitView();
this._children.forEach(c => c.instance.disableLayout = true);
this._children.forEach(child => {
child.orientation = orientation;
this._splitView.addView(child, 1);
this._withDisabledLayout(() => {
this._children.forEach(child => {
child.orientation = orientation;
this._splitView.addView(child, 1);
});
});
}
private _withDisabledLayout(innerFunction: () => void): void {
// Whenever manipulating views that are going to be changed immediately, disabling
// layout/resize events in the terminal prevent bad dimensions going to the pty.
this._children.forEach(c => c.instance.disableLayout = true);
innerFunction();
this._children.forEach(c => c.instance.disableLayout = false);
}
}