development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

npm task provider should not provide pre, post scripts - #30843

Browse source
This commit is contained in:
Erich Gamma 2017-07-19 11:58:39 +02:00
parent 712c489f5a
commit 6716723d9c
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
extensions/npm/src/main.ts
View file

@ -94,6 +94,10 @@ function getNpmCommandLine(script: string): string {
return `npm run ${script}`;
}
function isNotPreOrPostScript(script: string): boolean {
return !(script.startsWith('pre') || script.startsWith('post'));
}
async function getNpmScriptsAsTasks(): Promise<vscode.Task[]> {
let workspaceRoot = vscode.workspace.rootPath;
@ -108,11 +112,6 @@ async function getNpmScriptsAsTasks(): Promise<vscode.Task[]> {
return emptyTasks;
}
let silent = '';
if (vscode.workspace.getConfiguration('npm').get<boolean>('runSilent')) {
silent = '--silent';
}
try {
var contents = await readFile(packageJson);
var json = JSON.parse(contents);
@ -121,7 +120,7 @@ async function getNpmScriptsAsTasks(): Promise<vscode.Task[]> {
}
const result: vscode.Task[] = [];
Object.keys(json.scripts).forEach(each => {
Object.keys(json.scripts).filter(isNotPreOrPostScript).forEach(each => {
const kind: NpmTaskDefinition = {
type: 'npm',
script: each
@ -135,7 +134,7 @@ async function getNpmScriptsAsTasks(): Promise<vscode.Task[]> {
}
result.push(task);
});
// add some 'well known' npm tasks
// always add npm install (without a problem matcher)
result.push(new vscode.Task({ type: 'npm', script: 'install' } as NpmTaskDefinition, `install`, 'npm', new vscode.ShellExecution(`npm install`), []));
return Promise.resolve(result);
} catch (e) {