development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

New window opens behind existing windows (fix #149394) (#150530)

Browse source
This commit is contained in:
Benjamin Pasero 2022-05-27 14:51:19 +02:00 committed by GitHub
parent 5c77ef5850
commit 6682d2f3fd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vs/platform/windows/electron-main/window.ts
View file

@ -307,7 +307,15 @@ export class CodeWindow extends Disposable implements ICodeWindow {
this.setFullScreen(true);
}
if (!this._win.isVisible()) {
if (
!this._win.isVisible() ||
// TODO@electron: Required condition ever since https://github.com/electron/electron/pull/33536
// landed in Electron 17.4.2: calling `window.maximize()` on macOS will wrongly result in
// `window.isVisible()` to return `true` even though a different window might still be on top.
// As such, we also need to ask for `window.isFocused()` which on macOS will ask whether the
// window is a "key" window.
(isMacintosh && !this._win.isFocused())
) {
this._win.show(); // to reduce flicker from the default window size to maximize, we only show after maximize
}
mark('code/didMaximizeCodeWindow');
@ -792,7 +800,6 @@ export class CodeWindow extends Disposable implements ICodeWindow {
this.focus({ force: true });
this._win.webContents.openDevTools();
}
}, 10000)).schedule();
}